screenshot: Call vkInvalidateMappedMemoryRanges, request host cached memory - #2686
Conversation
|
Author th3or14 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
th3or14
changed the title
|
Author th3or14 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
Author th3or14 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI VulkanTools build queued with queue ID 35249. |
|
CI VulkanTools build # 5318 running. |
|
CI VulkanTools build # 5318 aborted. |
|
CI VulkanTools build queued with queue ID 35488. |
|
CI VulkanTools build # 5319 running. |
|
CI VulkanTools build # 5319 passed. |
Call vkInvalidateMappedMemoryRanges before reading the mapped memory on the host because the mapped memory is created without VK_MEMORY_PROPERTY_HOST_COHERENT_BIT.
Attempt to create the mapped memory with VK_MEMORY_PROPERTY_HOST_CACHED_BIT for performance boost. Fallback on a memory type without this property if it's not supported.
|
Author th3or14 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
Rebased on top of main in case the failing macOS job had been a blocker. |
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
It looks reasonable - I tried this out locally and didn't hit any issues. Well thats not true, I found out that screenshot doesnt handle SFLOAT swapchain image formats, but thats unrelated to your changes. Apologies for the delay in review.
|
CI VulkanTools build queued with queue ID 58888. |
|
CI VulkanTools build # 5348 running. |
|
CI VulkanTools build # 5348 passed. |
4 participants
Addresses #2685. @charles-lunarg Please review.