Repository navigation
feat: align plan tiers with upstream /status naming - #202
Merged
Merged
Conversation
Upstream added ProMax and finer-grained business/edu/research wire values; /status now shows the pro family as Pro 100/Pro 200/Pro 500 and labels tiers like Business Premium and Enterprise (Automation). codex-auth normalized everything past prolite to unknown and still printed "Pro Lite"/"Pro". - PlanType gains promax, business_premium, enterprise_automation, edu_plus, edu_pro, sci, sci_plus; planLabel mirrors upstream /status display names - normalizePlanType recognizes the new wire aliases (promax, self_serve_business_prolite, enterprise_cbp_automation, ent26, edu_plus, edu_pro, sci, sci_plus); parseStoredPlanType keeps the schema-4 split so stored tag names and wire values stay distinct - list --json keeps emitting normalized tag names for the new tiers; isWorkspaceAccount treats every workspace tier as workspace - writeTruncated trims a prefix ending on a word boundary so "Pro 200"-style labels truncate to "Pro." instead of "Pro .", which read as a standalone dot-only cell
Contributor
 [Medium impact] The PR appears safe to merge; the latest change preserves JSON output. SummaryAdds the new plan tiers and aligns their display labels with upstream
Reviews (3) · Last reviewed commit: "refactor: inline the single planName cal..." · Reviewed by Greptile |
@loongphy/codex-auth-darwin-arm64
@loongphy/codex-auth-darwin-x64
@loongphy/codex-auth-linux-arm64
@loongphy/codex-auth-linux-x64
@loongphy/codex-auth-win32-arm64
@loongphy/codex-auth-win32-x64
@loongphy/codex-auth
commit: |
The explicit switch returned the tag spelling for every variant, and the registry file already derives the same contract from Stringify's default enum serialization, so the table only duplicated @TagName.
The Option adapter had exactly one caller; @TagName reads fine at the call site with the contract note moved alongside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlanTypewithpromax,business_premium,enterprise_automation,edu_plus,edu_pro,sci,sci_plusso wire values upstream added no longer collapse tounknown.planLabelmirrors upstream/statusnames:prolite→Pro 100,pro→Pro 200,promax→Pro 500, plusBusiness Premium,Enterprise (Automation),Edu Plus/Edu Pro,Academic Researchers (Plus).normalizePlanTyperecognizes the new wire aliases (promax,self_serve_business_prolite,enterprise_cbp_automation,ent26,edu_plus,edu_pro,sci,sci_plus);parseStoredPlanTypekeeps the schema-4 split so stored tag names and wire values stay distinct ("business"reads.businessat v4,.enterprisepre-v4).list --jsonkeeps emitting normalized tag names for the new tiers;isWorkspaceAccountcovers every workspace tier.writeTruncatedtrims a prefix ending on a word boundary soPro 200truncates toPro.instead ofPro ., which read as a dot-only cell.Test plan
zig buildzig build test test-helpers— full suite greenzig build -Doptimize=ReleaseSafeCODEX_HOMEe2e: schema-4 tag round-trip, schema-2 wire-alias normalization, TUI labels