Skip to content

chore: update Go setup and govern Node type majors #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lojhan merged 1 commit into from
Oct 27, 2026
Merged

chore: update Go setup and govern Node type majors #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ updates:
open-pull-requests-limit: 10
commit-message:
prefix: deps
# Node type majors are reviewed with the supported runtime matrix.
ignore:
- dependency-name: "@types/node"
update-types: ["version-update:semver-major"]

- package-ecosystem: github-actions
directory: /
Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
# Node 22.11 compatibility floor.
node-version: 22.13
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
with:
node-version: ${{ matrix.node }}
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -152,7 +152,7 @@ jobs:
with:
node-version: 22.11
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
with:
node-version: 22.11
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -282,7 +282,7 @@ jobs:
with:
node-version: 22.11
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -324,7 +324,7 @@ jobs:
with:
node-version: 22.11
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -358,7 +358,7 @@ jobs:
with:
node-version: 22.13
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -392,7 +392,7 @@ jobs:
with:
node-version: ${{ matrix.node }}
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -434,7 +434,7 @@ jobs:
with:
node-version: ${{ matrix.node }}
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -521,7 +521,7 @@ jobs:
with:
node-version: 24
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -551,7 +551,7 @@ jobs:
with:
node-version: 22.13
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -588,7 +588,7 @@ jobs:
with:
node-version: 22.13
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -618,7 +618,7 @@ jobs:
with:
node-version: 24
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/editor-marketplaces.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
with:
node-version: 24
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
with:
node-version: 22.14
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
with:
node-version: 22.14
cache: pnpm
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
node-version: 24
package-manager-cache: false
- run: npm install --global npm@12.2.1
- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.27.3
cache: false
Expand Down
10 changes: 9 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ TYPED_SQL_CONTAINER_ENGINE=podman pnpm e2e:packed

Replace `podman` with `docker` when appropriate.

## Maintain dependencies

The development baseline uses Node.js 24 type declarations while runtime compatibility is
verified separately at the documented Node.js minimum and current supported versions. Review
major `@types/node` upgrades explicitly against that runtime matrix; Dependabot continues to
propose compatible updates within the current major. Do not treat a newer type declaration
package as evidence that newer Node.js APIs are available at the runtime minimum.

## Add tests where behavior lives

Tests use [Poku](https://poku.io/) and are ordinary TypeScript programs. Put a test in the package
Expand All @@ -59,7 +67,7 @@ pnpm --filter ./editors/vscode package:vsix
pnpm --filter ./editors/vscode test:host
```

The suite downloads VS Code 1.134.0 and installs the VSIX into separate extension/profile
The suite downloads VS Code 1.140.0 and installs the VSIX into separate extension/profile
directories for trusted, Restricted Mode, virtual-workspace and real-overlay scenarios. The first
three use a controlled server probe to assert whether the client executes workspace code. The
overlay matrix uses PostgreSQL, MySQL, SQLite and the synthetic third-party grammar, built workspace
Expand Down
Loading