Skip to content

ci: replace OpenCppCoverage with Microsoft native coverage - #220

Merged
ReenigneArcher merged 2 commits into
masterfrom
codex/msvc-coverage-without-ps
Nov 4, 2026
Merged

ReenigneArcher merged 2 commits into
masterfrom
codex/msvc-coverage-without-ps

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Description

Replace the archived OpenCppCoverage dependency in the MSVC CI job with Visual Studio's bundled Microsoft.CodeCoverage.Console. Configure the collector through an XML template and keep collection, result validation, and path normalization in the workflow.

Enable /PROFILE /INCREMENTAL:NO only for the GoogleTest executable, instrument that executable, and restore it after collection. Preserve Cobertura and GoogleTest report outputs and the existing source filters. GCC/Clang coverage continues to use gcovr.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

Local validation:

  • MSVC Debug test executable and gamepad adapter builds passed.
  • UCRT64 Debug library and gamepad adapter builds passed.
  • Selected MSVC report, profile, backend, and broker tests: 64 passed; 5 installed-broker tests skipped because the service was unavailable.
  • check-package-coverage.sh passed for both builds.
  • actionlint, yamllint, cmake-lint, XML/PowerShell parsing, and git diff --check passed.

No new test files are included for this workflow integration. The native collector is unavailable in the local Visual Studio Community installation.

Hosted validation on add599d passed for Windows MSVC (including test execution, native coverage collection, and report normalization), Windows MinGW/UCRT64, Linux GCC/Clang, FreeBSD, CodeQL, and common lint. Both macOS jobs were cancelled because GitHub could not allocate hosted runners.

Corrected a Read the Docs failure caused by the XML-template link in the development guide. Strict local Doxygen generation reproduces the unresolved reference before the correction and passes afterward. Hosted validation of the documentation correction is pending.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

Codex assisted with implementation, validation, and the PR description.

Generated by Codex (GPT-6; thinking level not exposed in this session).

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.18%. Comparing base (9f4cac3) to head (7c66a45).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   73.62%   73.18%   -0.45%     
==========================================
  Files          44       44              
  Lines       10705     9810     -895     
  Branches     3651     3651              
==========================================
- Hits         7882     7179     -703     
+ Misses       2182     1999     -183     
+ Partials      641      632       -9     
Flag Coverage Δ
FreeBSD 53.99% <ø> (ø)
Linux-Clang 68.59% <ø> (ø)
Linux-GCC 80.55% <ø> (ø)
PowerShell 75.60% <ø> (ø)
Windows-MSVC 73.47% <ø> (-0.74%) ⬇️
Windows-MinGW-UCRT64 66.22% <ø> (-0.06%) ⬇️
macOS 50.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 29 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4cac3...7c66a45. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit 4847ea0 into master Nov 4, 2026
36 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/msvc-coverage-without-ps branch November 4, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant