Skip to content

fix(ci): allow SDL access to UHID input nodes - #210

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-linux-sdl-playstation-detection
Oct 28, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-linux-sdl-playstation-detection

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

The Linux SDL2 DualSense and DualShock 4 USB tests cannot detect their controllers when the runner cannot read the evdev nodes. hid-playstation omits phys on those input devices, so the existing CI permission rule does not match them. Match their UHID ancestry with KERNELS=="uhid" so the unprivileged test process can use them.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Built test_libvirtualhid and gamepad_adapter in an isolated Ubuntu container.
  • Used a QEMU VM with real UHID devices, Linux 7.3, systemd-udevd 261.3, and upstream SDL 2.32.10, matching the failing runner's SDL version.
  • With the original CI rule, all four PlayStation tests pass as root, while UID 1000 reproduces both USB detection failures; the two Bluetooth tests pass.
  • With only the CI rule changed, the same binaries pass all four PlayStation tests as both root and UID 1000, including live USB controller input.
  • udevadm verify, bash -n on the Linux dependency-setup step, and git diff --check passed.

The existing integration tests provide the before/after regression coverage. No new C++ tests are needed for this CI permission-rule change; no library source or controller behavior is modified.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

Generated with Codex using gpt-6.1-sol, thinking level xhigh.

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.67%. Comparing base (99617a5) to head (8bd9c6a).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   73.57%   73.67%   +0.10%     
==========================================
  Files          44       44              
  Lines       10682    10682              
  Branches     3642     3642              
==========================================
+ Hits         7859     7870      +11     
+ Misses       2226     2215      -11     
  Partials      597      597              
Flag Coverage Δ
FreeBSD 53.99% <ø> (ø)
Linux-Clang 68.59% <ø> (ø)
Linux-GCC 80.55% <ø> (ø)
PowerShell 75.60% <ø> (ø)
Windows-MSVC 74.19% <ø> (+0.15%) ⬆️
Windows-MinGW-UCRT64 66.22% <ø> (+0.15%) ⬆️
macOS 50.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99617a5...8bd9c6a. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit e5b8d58 into master Oct 28, 2026
33 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-linux-sdl-playstation-detection branch October 28, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant