Repository navigation
fix(ci): allow SDL access to UHID input nodes - #210
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 73.57% 73.67% +0.10%
==========================================
Files 44 44
Lines 10682 10682
Branches 3642 3642
==========================================
+ Hits 7859 7870 +11
+ Misses 2226 2215 -11
Partials 597 597
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Linux SDL2 DualSense and DualShock 4 USB tests cannot detect their controllers when the runner cannot read the evdev nodes.
hid-playstationomitsphyson those input devices, so the existing CI permission rule does not match them. Match their UHID ancestry withKERNELS=="uhid"so the unprivileged test process can use them.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
test_libvirtualhidandgamepad_adapterin an isolated Ubuntu container.udevadm verify,bash -non the Linux dependency-setup step, andgit diff --checkpassed.The existing integration tests provide the before/after regression coverage. No new C++ tests are needed for this CI permission-rule change; no library source or controller behavior is modified.
Type of Change
Checklist
AI Usage
See our AI usage policy.
Generated with Codex using gpt-6.1-sol, thinking level xhigh.