Skip to content

fix(packaging): include HIDMaestro MIT notice - #209

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-hidmaestro-license-notice
Oct 28, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-hidmaestro-license-notice

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

The Windows PID descriptor uses HIDMaestro's MIT-licensed block, but its notice was missing from installed distributions. Include the complete upstream notice in library installs and the driver MSI, document the attribution, and add a CI check for missing or altered packaged license files.

Also correct HIDMaestro's ARM64, keyboard, and mouse support entries in the README.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • MSYS2/UCRT64 Release: built the library and gamepad_adapter, installed the library, and verified the installed HIDMaestro notice matches its source SHA-256.
  • MSVC/WDK Release: built the UMDF driver/catalog, setup helper, broker, gamepad_adapter, and virtualhid_control; generated the WiX MSI and verified all three extracted license files match their sources.
  • Ran the new CI verification against the packaged files: intact notices pass; a missing or altered HIDMaestro notice fails.
  • Confirmed the 1,029 PID descriptor bytes and vendored license text match upstream; verified README table alignment, clang-format --dry-run --Werror, and git diff --check.

This change affects license packaging and documentation; runtime behavior is unchanged. No installed-device checks were run.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

Generated with Codex using gpt-6.1-sol, thinking level xhigh.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
385 2 383 2
View the top 2 failed test(s) by shortest run time
LinuxConsumerTest::SdlSeesDualShock4UsbControllerBehavior
Stack Traces | 3.14s run time
.../tests/unit/test_linux_consumers.cpp:586
Expected: (joystick_index) >= (0), actual: -1 vs 0
LinuxConsumerTest::SdlSeesDualSenseUsbControllerBehavior
Stack Traces | 3.16s run time
.../tests/unit/test_linux_consumers.cpp:586
Expected: (joystick_index) >= (0), actual: -1 vs 0

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@ReenigneArcher
ReenigneArcher merged commit e1436f5 into master Oct 28, 2026
50 of 54 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-hidmaestro-license-notice branch October 28, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HIDMaestro's MIT notice for the PID block

1 participant