Repository navigation
fix(linux): target absolute input at the captured monitor - #6055
Draft
ReenigneArcher wants to merge 4 commits into
Draft
ReenigneArcher wants to merge 4 commits into
ReenigneArcher wants to merge 4 commits into
Conversation
Member
Author
|
Bundle ReportBundle size has no change ✅ |
Forward the streamed connector to libvirtualhid for KDE Wayland touch and pen assignment. Preserve negative desktop origins across capture backends and exclude client letterboxing from native pointer normalization. Pin the preceding libvirtualhid output-mapping fix and cover desktop geometry, monitor retargeting, and normalized input with regression tests.
Keep make_port documentation on its header declaration so strict Doxygen builds do not merge duplicate parameter blocks. Refresh the libvirtualhid pin to its preceding Sonar cleanup.
Use scoped initialization and const framebuffer metadata in KMS helpers, make the capture callback generic, and force expression parsing for the test dispatch call. Pin libvirtualhid's final fixture and complexity cleanup.
ReenigneArcher
force-pushed
the
codex/fix-linux-input-monitor
branch
from
November 6, 2026 00:23
4b65326 to
1bb695d
Compare
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6055 +/- ##
==========================================
+ Coverage 47.64% 49.02% +1.38%
==========================================
Files 140 143 +3
Lines 30896 31264 +368
Branches 13058 13383 +325
==========================================
+ Hits 14720 15327 +607
+ Misses 14776 13846 -930
- Partials 1400 2091 +691
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 43 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #6055 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: AppImage-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
|
sunshine_tray_menu.png |
 |
|
sunshine_tray_pairing_request.png |
 |
|
sunshine_tray_paused.png |
 |
|
sunshine_tray_stopped.png |
 |
|
sunshine_tray_streaming.png |
 |
|
sunshine_tray_tooltip.png |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
|
sunshine_tray_menu.png |
 |
|
sunshine_tray_pairing_request.png |
 |
|
sunshine_tray_paused.png |
 |
|
sunshine_tray_stopped.png |
 |
|
sunshine_tray_streaming.png |
 |
|
sunshine_tray_tooltip.png |
 |
2 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On KDE Wayland, streaming DP-1 can leave native touch and pen input assigned to HDMI-A-1. Forward the captured connector name through the Linux capture and input pipelines so libvirtualhid can assign its virtual devices to the streamed output. Preserve negative desktop origins and exclude client letterboxing when normalizing touch/pen coordinates.
This draft depends on LizardByte/libvirtualhid#221. The submodule currently points to its
86da2c2branch commit; update the gitlink to the merged library commit before marking this PR ready. Automatic device assignment is specific to KDE Wayland; other compositors retain their existing device mapping.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Validated locally in a Fedora Linux container with a virtual X display and null audio sink; CUDA, Vulkan, and tray support were disabled:
Real multi-monitor KDE/uinput behavior and native Windows/macOS Sunshine builds were not validated locally. Plasma 6.5.1 or later is recommended for reliable runtime device reassignment.
The strict Dockle/Doxygen 1.18.0 documentation build passes locally after rebasing onto
master(774be88e; 1,131 themed HTML pages). The Read the Docs failure in build 35684696 was caused by duplicatemake_port()parameter documentation in its declaration and definition; the complete documentation is now kept on the header declaration. Read the Docs build 35685331 passed for the pre-rebase4b653262commit.After the Sonar refactors, the input regression source passed native Clang syntax validation, and formatting/diff checks passed. The final dependency pin includes the unavailable-then-available capability regression and confirmed-assignment caching fix from libvirtualhid. The latest full Linux build/test matrix remains in hosted CI.
Type of Change
Checklist
AI Usage
See our AI usage policy.
Codex assisted with investigation, implementation, regression tests, documentation, and this PR description.