Repository navigation
feat: wire the custom brand mark, replace the cpu SF Symbol - #9
Merged
Merged
Conversation
- Package.swift bundles Resources/Images (mirrors the existing Fonts resource), loaded via Bundle.module same as AppFonts - BrandMark: loads the light/dark SVG (NSImage supports SVG natively on macOS 12+) matching the current colorScheme, cached per appearance; extracted as its own View since colorScheme isn't reliably readable from the App/Scene body - Dropped .foregroundColor(.secondary): the SVGs are already colored images, not a template glyph - README header now shows the 16-plate logo variant (has its own background, meant standalone) Not done: no .icns/.dmg icon pipeline in release.yml yet (there wasn't one before this change either) -- the app and .dmg still ship with no custom icon. Separate follow-up. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vag2FZvTekVg34kUeb791Q
Lixeas
added a commit
that referenced
this pull request
Sep 25, 2026
feat: wire the custom brand mark, replace the cpu SF Symbol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Package.swiftbundlesResources/Images(mirrors the existing Fonts resource)BrandMark: loads the light/dark SVG (NSImage decodes SVG natively on macOS 12+) matching the currentcolorScheme, cached per appearance.foregroundColor(.secondary)— the SVGs are already colored, not a template glyphNot done
No
.icns/.dmgicon pipeline inrelease.ymlyet (wasn't one before this either) — app/dmg still ship with the default generic icon. Separate follow-up.Test plan
swift build/swift testvia the Test workflow (self-hosted runner) — real SVG decode via NSImage, needs actual macOS🤖 Generated with Claude Code