Repository navigation
fix: localize the Settings window title - #8
Merged
Merged
Conversation
Window("Reglages", id: "settings") was a hardcoded literal, never routed
through Strings when the EN/FR toggle was added -- title stayed "Reglages"
regardless of the selected language.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vag2FZvTekVg34kUeb791Q
Lixeas
added a commit
that referenced
this pull request
Sep 25, 2026
fix: localize the Settings window title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Window("Reglages", id: "settings")was a hardcoded literal, missed when the EN/FR toggle was added — the Settings window title stayed "Reglages" regardless of the selected language.Test plan
swift build/swift testvia the Test workflow (self-hosted runner)🤖 Generated with Claude Code