Repository navigation
fix: generate a real app icon, document brew trust - #14
Merged
Merged
Conversation
- Scripts/generate-icon.swift: rasterizes the vector brand SVG to every size iconutil needs (NSImage draws it as vector, not a scaled-up 16px bitmap), packed into AppIcon.icns and copied into the bundle before codesign. Info.plist now sets CFBundleIconFile. The app and .dmg had no icon at all before this (default generic icon). - README: brew trust --cask is now a required one-time step before install (Homebrew 6.0 requires explicit trust for non-official taps) -- users were hitting this prompt unexplained. Not verified locally: no macOS/Swift toolchain on this machine. Logic is straightforward (NSImage vector draw + iconutil) but the actual icon needs checking on the next real release run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scripts/generate-icon.swiftrasterizes the vector brand SVG to every sizeiconutilneeds, packed intoAppIcon.icns, copied into the bundle before codesign, referenced viaCFBundleIconFile. The app/.dmg had no custom icon at all before this.brew trust --caskas a required one-time step (Homebrew 6.0+ requires explicit trust for non-official taps).Not verified
No macOS/Swift toolchain on this machine to test
Scripts/generate-icon.swiftdirectly. Logic is a straightforward NSImage vector draw +iconutil, but the actual rendered icon needs a look on the next real tagged release.Test plan
swift build/swift teststill pass (script lives outside the SPM package, untouched by these)NotchWatch.appshows a real icon in Finder/Applications