Repository navigation
Fix fSELF program header offset for SPRXPatcher ELFs - #160
Merged
Merged
Conversation
Signed-off-by: Cris <36153368+Cri4Key@users.noreply.github.com>
Contributor
Author
|
The fix in upstream RPCS3 has been merged in RPCS3/rpcs3#19906 RPCS3 builds after that will work again as long as this PR is merged and users perform the game patching again by using the updated version of Refresher with this fix |
Contributor
|
Really cool, I'll test this PR on the new RPCS3 build later, and then I will merge. |
Contributor
|
Works as expected on all 3 mainlines, they no longer crash for me once I repatch them with the build from the workflow, thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FakeEncryptGameEbootStep assumes the program header table starts right after the ELF header. This is correct for original, untouched EBOOTs, but ELFs patched via SPRXPatcher have such table moved at the end of the file and thus the offset needs to be recomputed correctly and the table data copied at the right place. This has never been a problem so far on RPCS3 as it was ignored, but recent RPCS3 upstream changes now rely on it effectively making it now unusable on newer RPCS3 releases.
While this fix is supposed to make things correct now on Refresher side when making the fSELF, it still needs a change on RPCS3 upstream to be able to still make use of such patched ELF to load the SPRX. I have asked for implementing such changes on an hotfix PR of theirs that is supposed to fix the problem.
I'd suggest not merging this until they do that.
If RPCS3 implements the necessary fix, this PR will solve #159