Repository navigation
feat(ui): default to top navbar + stacked pages, restore v1.6.1 layout - #456
Merged
Merged
Conversation
… layout metrics - Default layout is now the top navigation bar with stacked (non two-pane) pages. - Top bar back to v1.6.1: 48dp, tabs centred, 13sp, no pill behind the active tab. - Shared tokens back to v1.6.1: cards 8dp without border, buttons and inputs 8dp, tags 4dp, page title 22sp, horizontal segmented controls as separate tab pills. - Page layouts (home, instances, instance settings, settings, about, content, mods, external mods, CurseForge, news, quick launch, accounts) use v1.6.1 sizes, spacing, borders and arrangement; page headers sit on the background. - Content and colors are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the top navigation bar and stacked (non two-pane) pages the default, and reverts all layout metrics (sizing, spacing, borders, arrangement) to Android v1.6.1. Content and colors are unchanged.
Changes
UiSettings:layout_modedefaults tonavbar,two_pane_pagesdefaults tofalse(existing users keep what they chose).shell_navbar.xml): v1.6.1 structure. 48dp tall; tabs centred on the bar at 13sp; 36dp news/theme buttons; 32dp avatar. The active tab is bold primary text with no pill; the others use secondary text.SegmentedControldraws separate 32dp tab pills with 8dp gaps instead of a track.Testing
testDebugUnitTestlocally: the only failures are package-engine tests that need symlink privileges or git on Windows; no UI tests failed.