fix(transfer): transfer list not parsing args.shown correctly#7618
Open
ElectricalBoy wants to merge 1 commit into
Open
fix(transfer): transfer list not parsing args.shown correctly#7618ElectricalBoy wants to merge 1 commit into
ElectricalBoy wants to merge 1 commit into
Conversation
hjpalpha
reviewed
Jun 7, 2026
| ', objectname ' .. objectNameSortOrder, | ||
| title = Logic.nilIfEmpty(args.title), | ||
| shown = Logic.nilOr(Logic.readBoolOrNil(args.shown), true), | ||
| shown = Logic.readBool(args.shown), |
Collaborator
There was a problem hiding this comment.
this wanted?
it changes default behavior
Collaborator
Author
There was a problem hiding this comment.
because we are negating config.shown here, it doesn't change the default behavior
plus the current behavior is misleading because shown=true makes the list collapsed
hjpalpha
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reported on discord: https://discord.com/channels/93055209017729024/268719633366777856/1513098798388215879
How did you test this change?
trivial