Skip to content

Template inline player#7609

Draft
hjpalpha wants to merge 4 commits into
playerdisplay-widgetfrom
TemplateInlinePlayer
Draft

Template inline player#7609
hjpalpha wants to merge 4 commits into
playerdisplay-widgetfrom
TemplateInlinePlayer

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented Jun 5, 2026

stacked on #6863 as it uses stuff changed in that PR

prereq bot runs on sc/sc2:

  • touch run to populate Category:Pages with player hiddensort on sc/sc2
  • if that category gets entries fix them
  • write a conversion wrapper for sc/sc2 to replace player/player2 with inlinePlayer calls (so we can nuke the sc/sc2 custom stuff) https://liquipedia.net/commons/Module:Player/Display/Conversion
  • bot (subst) replace Template:Player and Template:Player2 across sc/sc2 wikis
    • "\{\{[pP]layer([^2])" "{{subst:#invoke:Player/Display/Conversion|run\1"
    • "\{\{[pP]layer2" "{{subst:#invoke:Player/Display/Conversion|run|flip=true"

Summary

  • idea is to gradually remove usage of Module:Player, Template:Player and Template:Player2 across wikis with a new template Template:InlinePlayer.
  • rollout needs conversion bot jobs with a conversion wrapper (yet to be created) for the subst bot runs
  • needs pos/role icon support added in the future to be able to convert wikis like LOL where the Player template supports that

How did you test this change?

untested, but function is (except for args -> props rename) identical to one of the functions on the /Starcraft module that gets removed with this PR

To-Do with merge

Delete the modules that get removed via this PR

Comment thread lua/wikis/commons/Player/Display.lua Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants