Repository navigation
fix(plugin:dashboard): keep the ETA for the remaining steps while a large include runs - #754
Merged
Merged
Conversation
…arge include runs An include_tasks or include_role is one step of the progress bar. The ETA subtracted the whole running time of the current step from the estimate for all steps left, so a long include such as the one of monitoring_plugins (install.yml with linux-source.yml, about 60 tasks) drove it to 00:00:00 with 60 steps to go. The steps after the running one now always count in full, and only the running step's own average share is counted down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
include_tasks/include_roleis one step of the dashboard progress bar. The ETA subtracted the whole running time of the current step from the estimate for all steps left, so a long include, such as the one ofmonitoring_pluginswith about 60 tasks, drove it to00:00:00with 60 steps to go.The steps after the running one now always count in full with the average time per step, and only the running step's own average share is counted down. A unit test covers a step that runs 30 times longer than the average.
🤖 Generated with Claude Code