Repository navigation
feat(plugin:dashboard): show the progress and ETA of the play, count ok results per host - #753
Merged
Merged
Conversation
…ok results per host The progress bar numbers the tasks the way the PlayIterator sees them: play.compile() with the tags filter applied, without meta tasks (they never fire v2_playbook_on_task_start) and without rescue sections. A task of an include_tasks or include_role is found through its parents, which lead to the include, so the include is one step. Verified against ansible-core 2.16, 2.18 and 2.22. The task counter shows "ok 13/22/35" (ok results, hosts still at work, hosts) instead of a separate pending counter. The counter columns are aligned to the widest value, so large run totals no longer run into the next label. The host list gets an O column, and LAST is renamed to LAST WORST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
linuxfabrik.lfops.dashboardstdout callback shows the progress of the play and how the hosts are doing.step 140/421 (33%) ETA 00:15:12. It counts the tasks of the play that are known when it starts, after--tags/--skip-tags. Aninclude_tasks/include_roleis one step, handlers andrescuesections are not counted. The ETA extrapolates the average time per finished step.ok 13/22/35: ok results, hosts still at work on the task, hosts. It replaces the separatependingcounter.Ocolumn with the ok results per host, andLASTis renamed toLAST WORST.Verified with ansible-core 2.16, 2.18 and 2.22: unit tests, plus a run with
include_tasks,include_role,when: false,block/rescue/always, a handler and--tags.🤖 Generated with Claude Code