Repository navigation
fix!: release bugs in duplicity, fangfrisch, gitlab_ce, icinga2_agent, mount, php, sshd and wordpress - #747
Open
NavidSassan wants to merge 9 commits into
Open
NavidSassan wants to merge 9 commits into
NavidSassan wants to merge 9 commits into
Conversation
…nd use STRATEGY=copy (fix #666)
…unless set (fix #734) The file task ran before the mount and with fixed defaults, so on the second run it reset the root of the mounted filesystem to root:root 0755. Owner, group and mode are now applied after mounting and only where set. The mount point is only created if it is missing, and not for `state: absent`.
A module that another package pulled in keeps the dnf reason "dependency" even if the inventory asks for it by name later, since installing an installed package is a no-op. Once the other package is gone, `dnf autoremove` takes the module. Red Hat family only.
…719) Safe now that the php role marks php-mysqlnd as user-installed first. The scenario recreates the state an older release left behind and checks that php-mysqlnd survives `dnf autoremove`.
NavidSassan
force-pushed
the
fix/release-bugs
branch
from
November 13, 2026 16:47
926f711 to
f4aa3c6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16, closes #534, closes #666, closes #681, closes #682, closes #719, closes #727, closes #734
What changes
One commit per role, each with its CHANGELOG lines and scenario changes.
dubareports a missing or invalid/etc/duba/duba.jsonwith an error message and exit code 201 or 203 instead of a traceback, and skips the cleanup of a path whose backup failed in the same run.gitlab-dump.serviceno longer ignores the exit code ofgitlab-backup create, and runs it withSTRATEGY=copy. Breaking: the backup path needs free space for the largest file store on top of the archive.root:root 0755on every run.modeis a new subkey.php-mysqlndinstead ofphp-mysql, and removesphp-pecl-mysqlfrom existing hosts.dnf mark install) before anything is removed. Without it, removingphp-pecl-mysqlleavesphp-mysqlndtodnf autoremove.[urlhaus]section is only written withfangfrisch__urlhaus_auth_keyset.sshd__sftp_subsystemfrom the inventory takes effect.Deviations from the issues
sshd__sftp_subsystemis no longer inmeta/argument_specs.yml. Its default references a variable fromvars/<platform>.yml, which is not loaded when the arguments are validated.modeis not a quoted octal string, and no longer creates the mount point forstate: 'absent'entries.mysql_*loses that extension; the CHANGELOG says how to keep it.Testing
molecule test(converge, idempotence, verify) passed for:duplicityon Rocky 9 and Debian 13gitlab_ceon Rocky 9mounton Rocky 9php/installon Rocky 9setup_wordpresson Rocky 9, including the migration fromphp-pecl-mysqlicinga2_agent,fangfrischandsshdhave no Molecule check for their fix and were tested by hand in a Rocky 9 container.dnf mark installwas also checked by hand on Rocky 8 and 10.The scenarios ran before the rebase onto the current
main; they were not repeated afterwards.pre-commitpasses on the rebased branch.The nftables fix for #721 is not part of this PR; it follows in a PR of its own.