Skip to content

fix!: release bugs in duplicity, fangfrisch, gitlab_ce, icinga2_agent, mount, php, sshd and wordpress - #747

Open
NavidSassan wants to merge 9 commits into
mainfrom
fix/release-bugs
Open

NavidSassan wants to merge 9 commits into
mainfrom
fix/release-bugs

Conversation

@NavidSassan

@NavidSassan NavidSassan commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Closes #16, closes #534, closes #666, closes #681, closes #682, closes #719, closes #727, closes #734

What changes

One commit per role, each with its CHANGELOG lines and scenario changes.

Deviations from the issues

  • sshd: sshd__sftp_subsystem is no longer in meta/argument_specs.yml. Its default references a variable from vars/<platform>.yml, which is not loaded when the arguments are validated.
  • mount: the role aborts if mode is not a quoted octal string, and no longer creates the mount point for state: 'absent' entries.
  • wordpress: a host that runs another application calling mysql_* loses that extension; the CHANGELOG says how to keep it.

Testing

molecule test (converge, idempotence, verify) passed for:

  • duplicity on Rocky 9 and Debian 13
  • gitlab_ce on Rocky 9
  • mount on Rocky 9
  • php/install on Rocky 9
  • setup_wordpress on Rocky 9, including the migration from php-pecl-mysql

icinga2_agent, fangfrisch and sshd have no Molecule check for their fix and were tested by hand in a Rocky 9 container. dnf mark install was also checked by hand on Rocky 8 and 10.

The scenarios ran before the rebase onto the current main; they were not repeated afterwards. pre-commit passes on the rebased branch.

The nftables fix for #721 is not part of this PR; it follows in a PR of its own.

…failed path (fix #534, fix #16)

duba ran the cleanup of a path even if its backup had just failed. duplicity
never deletes the active chain, so this did not remove the last backup, but
it shortened the history exactly when no new backup was coming in.
…unless set (fix #734)

The file task ran before the mount and with fixed defaults, so on the second
run it reset the root of the mounted filesystem to root:root 0755. Owner,
group and mode are now applied after mounting and only where set. The mount
point is only created if it is missing, and not for `state: absent`.
)

php-pecl-mysql is not removed from existing hosts: php-mysqlnd is installed
there as its dependency, and after the removal `dnf autoremove` would take it
(dnf 4.14 on Rocky 9).
A module that another package pulled in keeps the dnf reason "dependency"
even if the inventory asks for it by name later, since installing an
installed package is a no-op. Once the other package is gone,
`dnf autoremove` takes the module. Red Hat family only.
…719)

Safe now that the php role marks php-mysqlnd as user-installed first. The
scenario recreates the state an older release left behind and checks that
php-mysqlnd survives `dnf autoremove`.
@NavidSassan NavidSassan changed the title fix: release bugs in duplicity, fangfrisch, firewall, gitlab_ce, icinga2_agent, mount, php, sshd and wordpress fix: release bugs in duplicity, fangfrisch, gitlab_ce, icinga2_agent, mount, php, sshd and wordpress Nov 13, 2026
@NavidSassan NavidSassan changed the title fix: release bugs in duplicity, fangfrisch, gitlab_ce, icinga2_agent, mount, php, sshd and wordpress fix!: release bugs in duplicity, fangfrisch, gitlab_ce, icinga2_agent, mount, php, sshd and wordpress Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment