Repository navigation
Reexport NML headers - #4852
Open
BsAtHome wants to merge 2 commits into
Open
Reexport NML headers#4852BsAtHome wants to merge 2 commits into
BsAtHome wants to merge 2 commits into
Conversation
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reexports the NML headers. It does so by putting them in the
include/libnml/...andinclude/nml_intf/hierarchies. If someone needs it to be flattened, then they can simply add the appropriate-Ioptions to their private compile job (we got rid of most of them for good reason).The reexport also fixes collision prone double inclusion protection by using a proper prefix. All the
#includedirectives have been updated to use the proper<>style for the moved includes, unless an include file target is local to the directory of the file being compiled (and that also goes for includes including includes).This PR should fix some of the problems of #4774. There are many more changes and fixes to the NML stuff between 2.9 and master. Any use needs very, very careful attention if you try to interface using the binary interface and try to port 2.9 code to master and future 2.10.