Repository navigation
gladevcp: flush forwarded key events to AXIS - #4840
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
keyboard_forward() sends key events from an embedded GladeVCP panel to AXIS with python-xlib send_event(), which only queues the request in the client's output buffer. Nothing flushes it until the next round trip, the get_geometry() of the next forwarded key event. A KeyRelease therefore stays queued until another key is pressed, and an AXIS keyboard jog started with focus in the panel keeps running after the key is released. Flush after each send_event(). The fix was found by Jan (+Jan+ on the LinuxCNC forum). Fixes LinuxCNC#4839
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4839.
keyboard_forward()forwards key events from an embedded GladeVCP panel to AXIS with python-xlibsend_event(), which only queues the request. Nothing flushes it until the next forwarded key event, so the KeyRelease of the last key stays queued and an AXIS keyboard jog keeps running after the key is released. The fix is Jan's (+Jan+ on the forum):d.flush()aftersend_event().Tested on 2.9 with
configs/sim/axis/gladevcp/gladevcp_panel.iniunder Xvfb: click into the panel, hold Page_Down for 0.5 s, release, watch Z.