feat(SDK): warn instead of raising for unvetted instance types on studio start - #140
Merged
justusschock merged 2 commits intoAug 31, 2026
Merged
Conversation
…dio start Replace the NotSupportedError raised when a requested machine is not in the cloud account's known accelerator list with a UserWarning, so any instance type can be submitted. Unknown types are treated as custom instance types that haven't been vetted by Lightning — continue at your own risk. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
justusschock
requested review from
ethanwharris,
k223kim and
rusenask
as code owners
August 31, 2026 11:11
tchaton
approved these changes
Aug 31, 2026
websocket-client types ws.recv() as str | bytes; decode bytes to str before handing messages to the log parsers to satisfy mypy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
justusschock
deleted the
justus/instance-type-validation-warning-0a9f4c
branch
August 31, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows submitting any instance type to
Studio.start()again. The client-sideNotSupportedErrorraised when the requested machine isn't in the cloud account's known accelerator list is replaced with aUserWarningstating the machine is a custom instance type that hasn't been vetted by Lightning and that startup may fail — continue at your own risk.Details
Machine.from_stralready falls back to constructing an ad-hocMachinefor unrecognized strings, so custom types flow through end-to-end.machine_has_capacitycheck only fails for known machines explicitly marked out of capacity, so it doesn't block custom types either.NotSupportedErrorstays inlightning_sdk.exceptionsfor backwards compatibility (nothing else referenced it).test_studio_startis parametrized over supported/unsupported machines, asserting the unsupported case warns but still starts.🤖 Generated with Claude Code