Repository navigation
Conversation
Collapse certificates with the same subject name instead of throwing, so a previously signed PDF whose signature embeds a re-issued or cross-signed intermediate twice can still be signed. Related issue: LibreSign#9562 Type: Bugfix Signed-off-by: hubfc <183475170+hubfc@users.noreply.github.com>
|
Thanks for opening your first pull request in this repository! ✌️ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #9562
Summary
A chain may contain two certificates with the same subject (re-issued or cross-signed intermediates, seen with Izenpe).
ensureValidStructure()threw on that, so a PDF already signed with such a certificate could not be signed again.orderCertificates()now keeps the first certificate per name instead.How to test
Sign a PDF whose existing signature embeds two certificates with the same subject. Before:
Duplicate certificate names detected. After: it signs.Validation evidence
testDuplicateCertificateNamesKeepFirstOccurrence,testChainWithDuplicatedIntermediateIsOrderedphp-cs-fixercleanChecklist
AI (if applicable)