Skip to content

fix(l10n): Fix source strings reported at Transifex - #9561

Open
rakekniven wants to merge 1 commit into
LibreSign:mainfrom
rakekniven:fix/l10n-source-strings-transifex
Open

rakekniven wants to merge 1 commit into
LibreSign:mainfrom
rakekniven:fix/l10n-source-strings-transifex

Conversation

@rakekniven

Copy link
Copy Markdown
Contributor

📝 Summary

Fixes eight source strings that translators reported as issues at Transifex:

Before After Where
Parameter '%s' should be betweeen %s and %s. … between … ValidateService.php (3×)
Failure on generate certificate Failure to generate certificate (already used in the same file) SignEngineHandler.php
No signature was requested to %s … requested from %s SignFileService.php, NotifyService.php
Failed to remove file(s) from envelope Failed to remove one or more files from the envelope store/files.js
{count} denied requester groups n(): %n denied requester group / groups request-sign-groups/realDefinition.ts
{count} authorized requester groups n(): %n authorized requester group / groups request-sign-groups/realDefinition.ts
{count} enabled factors n(): %n enabled factor / factors identify-methods/realDefinition.ts
{value} days n(): %n day / days expiration-rules/realDefinitions.ts

The counts used t() with a placeholder, so translators had only one form for every number. Many languages need different forms, so they now use n(). The TRANSLATORS comments are updated to %n.

🧪 How to test

The tests that check these texts are updated: ValidateServiceTest.php, SignFileServiceTest.php and certificate_openssl.feature ("between", "requested from"). The JS l10n test mock already provides n().

✅ Checklist

  • The diff does not contain unrelated refactors or generated changes.
  • Commits follow Conventional Commits where applicable.
  • All commits include the required DCO sign-off.

🤖 AI (if applicable)

  • The content of this PR was partially or fully generated using AI

🤖 Generated with Claude Code

- Fix typo "betweeen"
- "Failure on generate certificate" -> "Failure to generate certificate"
- "No signature was requested to %s" -> "No signature was requested from %s"
- Avoid "file(s)" in "Failed to remove file(s) from envelope"
- Use plural forms for the counts of requester groups, enabled factors and days

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rakekniven
rakekniven requested a review from a team as a code owner November 19, 2026 07:00
@rakekniven

Copy link
Copy Markdown
Contributor Author

@vitormattos Please see my PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant