Repository navigation
fix(l10n): Fix source strings reported at Transifex - #9561
Open
rakekniven wants to merge 1 commit into
Open
rakekniven wants to merge 1 commit into
rakekniven wants to merge 1 commit into
Conversation
- Fix typo "betweeen" - "Failure on generate certificate" -> "Failure to generate certificate" - "No signature was requested to %s" -> "No signature was requested from %s" - Avoid "file(s)" in "Failed to remove file(s) from envelope" - Use plural forms for the counts of requester groups, enabled factors and days Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@vitormattos Please see my PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes eight source strings that translators reported as issues at Transifex:
ValidateService.php(3×)SignEngineHandler.phpSignFileService.php,NotifyService.phpstore/files.jsn(): %n denied requester group / groupsrequest-sign-groups/realDefinition.tsn(): %n authorized requester group / groupsrequest-sign-groups/realDefinition.tsn(): %n enabled factor / factorsidentify-methods/realDefinition.tsn(): %n day / daysexpiration-rules/realDefinitions.tsThe counts used
t()with a placeholder, so translators had only one form for every number. Many languages need different forms, so they now usen(). TheTRANSLATORScomments are updated to%n.🧪 How to test
The tests that check these texts are updated:
ValidateServiceTest.php,SignFileServiceTest.phpandcertificate_openssl.feature("between", "requested from"). The JS l10n test mock already providesn().✅ Checklist
🤖 AI (if applicable)
🤖 Generated with Claude Code