Skip to content

fix(l10n): Do not translate GeoIP database path placeholder - #9560

Open
rakekniven wants to merge 2 commits into
LibreSign:mainfrom
rakekniven:fix/l10n-geoip-path-placeholder
Open

rakekniven wants to merge 2 commits into
LibreSign:mainfrom
rakekniven:fix/l10n-geoip-path-placeholder

Conversation

@rakekniven

Copy link
Copy Markdown
Contributor

📝 Summary

The placeholder of the GeoIP database path field is a file system path (/var/lib/libresign/GeoLite2-City.mmdb). It was wrapped in t(), so it showed up at Transifex as a string to translate. This was reported there as an issue.

This PR uses the path as a plain string, so it is no longer extracted for translation. The placeholder shown in the UI does not change.

🧪 How to test

  1. Open the admin settings with the GeoIP database section.
  2. The path field still shows /var/lib/libresign/GeoLite2-City.mmdb as placeholder.

✅ Checklist

  • The diff does not contain unrelated refactors or generated changes.
  • Commits follow Conventional Commits where applicable.
  • All commits include the required DCO sign-off.

🤖 AI (if applicable)

  • The content of this PR was partially or fully generated using AI

🤖 Generated with Claude Code

The placeholder is a file system path, so there is nothing to translate.
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rakekniven
rakekniven requested a review from a team as a code owner November 18, 2026 18:52
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rakekniven

Copy link
Copy Markdown
Contributor Author

@vitormattos Please

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant