Repository navigation
[stable35] fix(mail): reject failed verification-code recipients - #9506
Merged
Merged
Conversation
fix(mail): handle rejected verification code recipients Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> [skip ci]
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
marked this pull request as ready for review
November 14, 2026 22:29
vitormattos
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9495 to
stable35.Stable-specific adaptation
The stable branch does not have the
MailService::sendAndCheck()helper frommain. The backport checks the result ofIMailer::send()directly and sends non-empty failed-recipient lists through the pre-existingLibresignExceptionpath, while preserving successful submissions and the stable's mail transport logic.Review handoff
stable35(GitHub mergeability checked).[skip ci]marker, so CI is enabled.Two focused MailService regression tests added (transport accepts [] and rejects a non-empty failed-recipient list). PHP syntax checks passed; GitHub CI is not yet claimed complete.
History: The backport bot's original commit includes
[skip ci]. It was not rewritten: later signed commits re-enabled CI while preserving the existing commit history. No merge performed.