Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/Listener/SignedCallbackListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

namespace OCA\Libresign\Listener;

use OCA\Libresign\Enum\FileStatus;
use OCA\Libresign\Events\SignedEvent;
use OCA\Libresign\Service\SignFileService;
use OCP\EventDispatcher\Event;
Expand All @@ -27,9 +28,10 @@ public function handle(Event $event): void {
return;
}

$updatedFields = $event->getLibreSignFile()->getUpdatedFields();
if (isset($updatedFields['signed']) && $updatedFields['signed'] === true) {
$this->signFileService->notifyCallback($event->getSignedFile());
if ($event->getLibreSignFile()->getStatus() !== FileStatus::SIGNED->value) {
return;
}

$this->signFileService->notifyCallback($event->getSignedFile());
}
}
53 changes: 53 additions & 0 deletions tests/php/Unit/Listener/SignedCallbackListenerTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<?php

declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2026 LibreCode coop and contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OCA\Libresign\Tests\Unit\Listener;

use OCA\Libresign\Db\File as FileEntity;
use OCA\Libresign\Enum\FileStatus;
use OCA\Libresign\Events\SignedEvent;
use OCA\Libresign\Listener\SignedCallbackListener;
use OCA\Libresign\Service\SignFileService;
use OCP\EventDispatcher\Event;
use OCP\Files\File;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\TestCase;

final class SignedCallbackListenerTest extends TestCase {
public static function completionStatuses(): array {
return [
'ready to sign' => [FileStatus::ABLE_TO_SIGN, false],
'partially signed' => [FileStatus::PARTIAL_SIGNED, false],
'completed' => [FileStatus::SIGNED, true],
];
}

#[DataProvider('completionStatuses')]
public function testLegacyCallbackOnlyFiresOnDocumentCompletion(FileStatus $status, bool $expected): void {
$document = new FileEntity();
$document->setStatus($status->value);
$signedFile = $this->createMock(File::class);
$event = $this->createMock(SignedEvent::class);
$event->method('getLibreSignFile')->willReturn($document);
$event->method('getSignedFile')->willReturn($signedFile);

$service = $this->createMock(SignFileService::class);
$service->expects($expected ? $this->once() : $this->never())
->method('notifyCallback')
->with($signedFile);

(new SignedCallbackListener($service))->handle($event);
}

public function testIgnoresUnrelatedEvents(): void {
$service = $this->createMock(SignFileService::class);
$service->expects($this->never())->method('notifyCallback');

(new SignedCallbackListener($service))->handle(new Event());
}
}
Loading