Repository navigation
fix(n8n): discover signed PDF via authorized WebDAV PROPFIND - #158
Merged
Merged
Conversation
After OCS confirms a single-document signature, list the requester's LibreSign folder with authenticated PROPFIND, locate the original source by its Nextcloud nodeId/oc:fileid, and require one unambiguous PDF sibling before downloading by the actual DAV href. Abort safely on missing or ambiguous permissions/files. Add Code-node regression coverage and pin n8n 2.47.3 import validation in documentation CI. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Contributor
Documentation: All versions · LibreSign 16 development manual · Review notes Preview is separate from production. LibreSign 16 has not been released; the development manual describes the upcoming version. |
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the manually supplied
signedPdfPathfrom the single-document external signer example introduced in #149. Keep public OCS + authorized Nextcloud WebDAV interfaces; do not invent LibreSign endpoints or infer signed filenames.Verified flow
After authorized OCS
/file/listreports status3for the precise file ID/UUID:PROPFIND Depth: 1the integration account's defaultLibreSign/DAV folder (same HTTPS origin and HTTP Basic App Password).PROPFINDeach folder foroc:fileid, MIME type and byte length.nodeIdwith DAVoc:fileid; require exactly one other nonempty PDF sibling, using the literal authorized DAVhrefreturned by Nextcloud (no filename construction).cryptographicSignatureVerified: falseuntil an external verifier runs).The workflow rejects missing/ambiguous matches, path traversal, absent node IDs, denied permissions and scans exceeding
maxSearchFolders(default 50, maximum 250). It is intentionally scoped to one document / one email signer and default LibreSign storage; not a generic envelope resolver.Evidence
node --test examples/n8n/test-workflow.mjs: 12/12 passed, including wrong source ID, missing signature, ambiguous sibling and path traversal.git diff --check: clean.pdfsig(signature valid, private test CA not trusted globally)..github/workflows/docs.ymlnow runs Node regression tests and a real n8n 2.47.3 import smoke check for future changes.Limitations and release parity
Signed commit with DCO. No production server changes, deployment or merge requested by this PR description.