Repository navigation
fix(ci): isolate documentation previews from privileged deployment - #157
Closed
vitormattos wants to merge 1 commit into
Closed
vitormattos wants to merge 1 commit into
vitormattos wants to merge 1 commit into
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
Superseded by #159. This PR duplicated Pages verification and sticky-comment scripting inside the privileged workflow. #159 instead reuses the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dependabot-originated
pull_requestjobs do not receive the organization GitHub App private key. The current PR preview workflow builds successfully and then fails atcreate-github-app-token; retrying the failed job as a maintainer does not change the original event's secret restrictions. Making secrets available inside a PR checkout would also unnecessarily widen a trust boundary.Change
workflow_rundeployment pipeline for all PRs instead of only forks. It checks out default-branch code, checks that the PR is still open and its current HEAD matches the completed run, downloads the HTML artifact from that exact run, and rejects symlinks/basic invalid layouts before obtaining the scoped Pages credential.Validation and limitations
private-keyinput despite Sphinx and other checks passing. build(deps): bump actions/download-artifact from 4 to 8 #135 and build(deps): bump actions/upload-artifact from 4 to 7 #137 succeeded only after maintainers triggered new runs.main, the trustedworkflow_runpublishes and verifies a Dependabot/fork preview without accessing secrets in the PR job. Do not treat a green unprivileged build as proof of published preview.Please review the security boundary and independent CI before merge; this change is not a bypass of required reviews.