Repository navigation
fix(ci): upgrade GitHub App token action with safe Dependabot fallback - #156
vitormattos wants to merge 1 commit into
Conversation
Upgrade to pinned actions/create-github-app-token 3.3.0 for trusted runs. Dependabot pull_request events do not have access to the Actions private-key secret, so publish an unprivileged artifact instead of attempting deployment with an empty key. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Documentation: All versions · LibreSign 16 development manual · Review notes Preview is separate from production. LibreSign 16 has not been released; the development manual describes the upcoming version. |
|
Closing as superseded by #159 (merged as The conflicts are caused by overlapping edits in Separate dependency audit: |
Why this PR
Dependabot #136 upgrades
actions/create-github-app-tokenfrom v2 to v3.3.0 but its preview run failed withprivate-key input must be set to a non-empty string. The triggering actor wasdependabot[bot]: this workflow context did not have the Actions private-key secret; re-running the same run as a maintainer did not change the actor.This trusted-maintainer PR allows the v3 update to be validated in a context where the scoped preview credentials are available, while fixing the underlying Dependabot-triggered behavior.
Changes
actions/create-github-app-token@64ab729a...(v3.3.0) in 3 preview workflows.dependabot[bot]PR runs, upload the unprivileged HTML preview artifact, exactly as for fork PRs; do not request the scoped GitHub App token or deploy/comment to the preview origin.app-idremains until the separate client-id variable is configured.Tests
Replaces the broken #136 path when checks pass; no deploy to the production documentation. Signed commit and DCO.