Repository navigation
docs(review): make review comments readable and require regression tests - #27
Merged
vitormattos merged 1 commit intoNov 9, 2026
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markdownblocks that force horizontal scrolling.suggestioncode fences for verified replacement code, with the explanation readable outside the fence.Motivation
A review of LibreSign/libresign#9375 exposed poor readability of long GitHub-ready comments when shown inside fenced Markdown blocks. The same feedback identified a need for review comments about bugs to require regression coverage rather than merely describing a potential fix.
Validation
mainrevision: only the intended three Markdown files changed.No changes were made to LibreSign/libresign#9375 by this PR.