Repository navigation
fix: bring the merged WordPress login link and billing re-enable fixes into main - #44
Merged
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…count Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…led-users fix: only enable again the users disabled for billing
fix: record the WordPress login link when creating the group admin account
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…tored Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…hangelog Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#35 → #36 → #37 → #38 were opened as a stack. #36 was merged into
fix/restrict-subadmin-group-additionsand reachedmainwith #35, but #37 was merged intofix/refuse-adopting-foreign-accountsa minute after #36 had already been merged, so #37 and #38 never reachedmain. This PR takesfix/refuse-adopting-foreign-accountsintomain. It carries both, plus the follow-ups below.What reaches
maincreateAdminGroupwrites the user preferencewordpress_login_backend/wordpress_loginwhen it creates the group admin account. fix: bring the merged linked account and squatting fixes into main wordpress_login_backend#32, already inmainthere, only accepts linked accounts, so without this the group admins created from now on cannot log in with their WordPress password.set-enabledwithenabled=0marks the users it disables withadmin_group_manager/disabled_by_billing;enabled=1and re-provisioning throughadmin-groupenable only the marked users and remove the mark. Users disabled by the group admin stay disabled.Follow-ups on top of #37 and #38
UserChangedEventremovesdisabled_by_billingwhen a user is enabled. Before, if an administrator enabled a member by hand during non-payment and the group admin later disabled that member on purpose, the next billing enable brought the member back.link-usersstep; the existing entry now says that the owner is enabled again.Deploy order
Deploy this before LibreSign/wordpress_login_backend#32, then run
occ wordpress-login-backend:link-users --dry-run, check the output and run it without--dry-runfor the accounts created before.Verification
mainwithout conflicts.composer run openapipass locally.