fix(bug): new git dependency made build_sys.sh fail. Added git as a dependency to fix it.#212
fix(bug): new git dependency made build_sys.sh fail. Added git as a dependency to fix it.#212barakiva wants to merge 1 commit into
Conversation
|
Sorry @barakiva , but I do not agree with your PR. compose install logs states: Since composer cannot find the binary file, it tries to download the source file, then wants to use git to process the source file. @JohnVillalovos, could you please check this composer package and see why the binary object is unavailable? Alternatively, could you use another composer package? |
@colisee We aren't seeing this issue in Librebooking. The CI there installs composer dependencies. Maybe this was a temporary failure? I can see: But I can download the file and unzip it now: |
|
@JohnVillalovos , you are likely right. I checked the daily image build and it ran successfully this morning. Henceforth, I will close this PR |
Interesting. I've seen it complain about needing git but did not realize it was about that temporary failure. Good catch! |
Heres the following logs from the failed build:
Build passes now. We should add a CI to prevent such bugs in the future.