Repository navigation
Give async render waits in the webview tests a 5s window - #43
Merged
Merged
Conversation
The App tests wait for nodes that only appear after the async ELK layout resolves, using waitFor's 1s default. The first layout in a run pays ELK's start-up cost: 656-717ms on recent CI runs, and over 1s on the slower runner that failed "renders tables passed via window.render" on #41 (every suite on that runner ran ~1.7x slower). Raise the Testing Library async timeout to 5s in the shared setup so runner variance cannot fail them.
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.1.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The App tests wait for nodes that only appear after the async ELK layout resolves, using
waitFor's 1s default. The first layout in a run pays ELK's start-up cost: 656-717ms on recent CI runs, and over 1s on the slower runner that failed "renders tables passed via window.render" on #41 (every suite on that runner ran ~1.7x slower).This raises the Testing Library async timeout to 5s in the shared test setup, so runner variance can't fail these tests. Waits still finish as soon as the element appears.