Skip to content

fix(encode): order ffmpeg inputs ahead of output options #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeadcodeDev merged 3 commits into from
Aug 8, 2026
Merged

fix(encode): order ffmpeg inputs ahead of output options #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52fb1b0
fix(encode): order ffmpeg inputs ahead of output options
LeadcodeDev Aug 8, 2026
e4e56b7
Merge branch 'chantier/audit-remediation' into fix/audit-lot1-ffmpeg-…
LeadcodeDev Aug 8, 2026
a1f0a74
style(encode): apply rustfmt to the ffmpeg argv builder
LeadcodeDev Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/rustmotion-core/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,14 @@ pub enum RustmotionError {
#[error("Failed to open FFmpeg stdin pipe")]
FfmpegPipe,

#[error("Failed to write to FFmpeg pipe: {reason}")]
FfmpegWrite { reason: String },
// A broken pipe here nearly always means ffmpeg already died on its own
// arguments, so the useful diagnostic is ffmpeg's stderr rather than our
// write error. Carry it in the error so it survives `--quiet`.
#[error("Failed to write to FFmpeg pipe: {reason}{}", .stderr.as_ref().map(|s| format!("\nffmpeg reported:\n{}", s)).unwrap_or_default())]
FfmpegWrite {
reason: String,
stderr: Option<String>,
},

#[error("Failed to wait for FFmpeg: {reason}")]
FfmpegWait { reason: String },
Expand Down
Loading
Loading