fix: handle missing _edges table in typed subgraph when creating edges#686
Merged
Conversation
When creating an edge via MATCH ... CREATE in a strongly-typed subgraph (not ANY), the code tried to look up '_edges' in the default graph catalog without checking if it exists. This caused a 'Catalog exception: _edges does not exist in catalog' error. Fix by checking containsTable() before accessing the _edges table, matching the pattern already used in bind_graph_pattern.cpp. Add test test_files/graph/typed_subgraph.test covering: - Creating a strongly-typed (non-ANY) subgraph - Creating node and rel tables in the subgraph - Creating nodes and edges with MATCH ... CREATE - Querying the created nodes and edges
adsharma
force-pushed
the
fix/typed-subgraph-edge-create
branch
from
0c22c5e to
07a4503
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating an edge via MATCH ... CREATE in a strongly-typed subgraph (not ANY), the code tried to look up '_edges' in the default graph catalog without checking if it exists. This caused a 'Catalog exception: _edges does not exist in catalog' error.
Fix by checking containsTable() before accessing the _edges table, matching the pattern already used in bind_graph_pattern.cpp.
Add test test_files/graph/typed_subgraph.test covering: