Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contracts/stream_contract/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,7 @@ impl StreamContract {
/// emits a `fee_collected` event, and returns the net amount.
///
/// If no protocol config exists or the fee rate is 0, returns `amount` unchanged.
/// If fee calculation truncates to 0, no transfer/event occurs and `amount` is unchanged.
/// Time complexity: O(1).
fn collect_fee(env: &Env, token_address: &Address, amount: i128, stream_id: u64) -> i128 {
match try_load_config(env) {
Expand Down
34 changes: 34 additions & 0 deletions contracts/stream_contract/src/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,40 @@ fn test_no_fee_event_when_fee_rate_is_zero() {
);
}

#[test]
fn test_no_fee_transfer_or_event_when_fee_rounds_to_zero() {
let env = Env::default();
env.mock_all_auths();
let (token, _) = create_token(&env);
let sender = Address::generate(&env);
let admin = Address::generate(&env);
let treasury = Address::generate(&env);
mint(&env, &token, &sender, 1_000);

let client = create_contract(&env);
let token_client = token::Client::new(&env, &token);

// Non-zero fee rate, but tiny amount => fee rounds down to 0:
// 1 * 200 / 10_000 = 0
client.initialize(&admin, &treasury, &200);
let id = client.create_stream(&sender, &Address::generate(&env), &token, &1, &1);

assert_eq!(token_client.balance(&treasury), 0);

let s = client.get_stream(&id).unwrap();
assert_eq!(s.deposited_amount, 1);

let events = env.events().all();
let fee_event = events.iter().find(|e| {
Symbol::try_from_val(&env, &e.1.get(0).unwrap()).unwrap()
== Symbol::new(&env, "fee_collected")
});
assert!(
fee_event.is_none(),
"fee_collected must not fire when rounded fee is 0"
);
}

#[test]
fn test_no_fee_without_protocol_config() {
let env = Env::default();
Expand Down
Loading