Add test for rounded-zero protocol fee#945
Open
Killerjunior wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add coverage for the untested
collect_feebranch wherefee_rate_bps > 0but fee rounds down to zero for tiny amounts, ensuring behavior is explicitly verified.Type of Change
Related Issues
Closes #794
Changes Made
contracts/stream_contract/src/test.rs:test_no_fee_transfer_or_event_when_fee_rounds_to_zero200 bps) and creates a stream with tiny amount (1) so fee calculation truncates to zero.0deposited_amountremains full amount (1)fee_collectedevent is emittedcollect_feedoc comment incontracts/stream_contract/src/lib.rsto explicitly describe the rounded-zero-fee behavior.Testing
Test Coverage
Test Steps
cargo test --manifest-path contracts/stream_contract/Cargo.toml test_no_fee_transfer_or_event_when_fee_rounds_to_zeroBreaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
N/A
Checklist
Additional Notes
link.exefailure; missing/incorrect C++ build tools setup), not due contract/test logic.test-794-fee-rounds-to-zero