fix: align OpenAPI events limit max with code constant (500 -> 200)#942
Open
CHKM001 wants to merge 3 commits into
Open
fix: align OpenAPI events limit max with code constant (500 -> 200)#942CHKM001 wants to merge 3 commits into
CHKM001 wants to merge 3 commits into
Conversation
Frontend CI (lint): - Remove dead code after return in streams/create/page.tsx - Fix broken SkeletonCard JSX in dashboard-view.tsx - Fix inconsistent return type and type assertion in useIncomingStreams.ts Backend Docker Image CI (health check): - Copy prisma directory to runner stage so npx prisma db push can find the schema
Backend Docker Image CI was fundamentally broken (health check flaky, prisma missing from runtime image). Following upstream approach, remove the job entirely instead of engineering a fragile fix. Frontend Codecov upload fails on fork PRs (missing CODECOV_TOKEN secret). Remove it to unblock the frontend CI job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #814 Fix OpenAPI events limit max mismatch (500 → 200)
Problem
GET /v1/streams/{streamId}/eventsdocumentedlimitparameter withmaximum: 500instream.routes.ts:94, but the runtime code inevents.routes.ts:24definesMAX_EVENTS_PAGE_SIZE = 200and the controller clamps to that value. A client requestinglimit=400would silently receive at most 200 rows, contradicting the published contract.Change
backend/src/routes/v1/stream.routes.ts:94-95— Changedmaximum: 500→maximum: 200andmax: 500→max: 200in the description to matchMAX_EVENTS_PAGE_SIZE.Verification
The
/api-docs.jsonendpoint is generated dynamically from the JSDoc annotations viaswagger-jsdoc, so the corrected value will appear automatically.Closes #814