Repository navigation
Copier update: Pyrefly implicit reexport for non libraries - #112
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Packages generated from this template are distributed libraries, so their public API should stay deliberate. The template repo's own .config/pyrefly.toml keeps the ignore, since it is not a distributed library. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: LabAutomationAndScreening/copier-python-package-template/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: LabAutomationAndScreening/copier-python-package-template/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change raises dependency minimums, updates Pyrefly error settings, and changes development-container tooling pins and metadata. ChangesTemplate dependency and tooling updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Other Merge Risk: ⚪ Minimal · up to No actionable issue is evidenced in the supplied changes, and the stricter template check is intentional. The PR appears ready subject to normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Might be overthinking it but do we want to actually keep that line and switch it to error and update the comment explaining why we switched it so that future us know why and we dont accidently merge a future pyrefly config update and it gets swapped back incorrectly? |
Documents the intentional divergence from the upstream template's "ignore" so a future copier update does not silently revert it: generated packages are distributed libraries whose public API must be deliberate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Good call — restored the line as Reply drafted by AI (Claude), reviewed and approved by the author before posting. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pull in upstream template changes
Do not let the suppression of that rule cascade into the pyrefly config for the actual library repo itself
Summary by CodeRabbit