Repository navigation
Copier update: fully remove pyright - #101
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe PR updates Claude command validation, migrates project checks from Pyright to Pyrefly, refreshes development tooling, synchronizes Copier template files, and adds shared pytest configuration. ChangesTooling and template maintenance
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/hooks/bash-chain-guard.js:
- Line 11: Update CHAIN_OPERATORS in both .claude/hooks/bash-chain-guard.js
lines 11-11 and template/.claude/hooks/bash-chain-guard.js lines 11-11 to match
unquoted newline command separators in addition to &&, ||, and semicolons, while
continuing to allow a single pipe character.
- Line 12: Update BACKGROUND_AMPERSAND in both .claude/hooks/bash-chain-guard.js
(lines 12-12) and template/.claude/hooks/bash-chain-guard.js (lines 12-12) to
exclude a preceding pipe, using the requested (?<![<>|])&(?!>) pattern so valid
|& pipelines are not matched.
- Around line 3-16: Make the guard shell-aware in both
.claude/hooks/bash-chain-guard.js (lines 3-16) and
template/.claude/hooks/bash-chain-guard.js (lines 3-16): update the parsing used
by stripQuotedAndEscaped and the operator checks so command substitutions and
quoted sh -c bodies cannot hide chained commands, unquoted newlines are rejected
as separators, and |& is treated consistently with the allowed pipeline policy.
Apply the same behavior in both copies.
In @.config/.copier-managed-files.json:
- Line 36: Review the changes to the listed Copier-managed paths and identify
which are generic rather than repository-specific. Backport those generic
changes to the authoritative
gh:LabAutomationAndScreening/copier-base-template.git, and leave
.config/.copier-managed-files.json unchanged because it is auto-generated.
In @.github/workflows/hash_git_files.py:
- Around line 99-100: Restore bounded chunked checksum reads in the regular-file
and extra_paths handling of .github/workflows/hash_git_files.py at lines 99-100
and 105-107, preserving CRLF-to-LF normalization without loading entire files
into memory. Apply the same streaming changes in
template/.github/workflows/hash_git_files.py at lines 99-100 and 105-107.
- Around line 99-100: Update both implementations of the file hashing logic to
normalize CRLF only for Git-classified text files, preserving raw bytes for
binary files. Apply this consistently to tracked-file hashing and extra_paths in
.github/workflows/hash_git_files.py at lines 99-100 and 105-107, and mirror the
same changes in template/.github/workflows/hash_git_files.py at lines 99-100 and
105-107, using Git text attributes or normalized Git blobs for classification.
In `@AGENTS.md`:
- Line 54: In AGENTS.md at line 54 and template/AGENTS.md at line 54, restore
the behavioral-assert guidance as its own bullet: keep behavioral assert
statements inside test functions, never ordinary helpers or fixtures. Add the
pytest keyword-only exception as a separate bullet below it, preserving both
rules in each file.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3765fbf9-a2a2-4603-ba47-2ade97909627
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (37)
.claude/hooks/bash-chain-guard.js.claude/settings/models.jsonc.claude/settings/permissions/bash.jsonc.claude/skills/address-pr-comments/fetch-pr-comments.py.coderabbit.yaml.config/.copier-answers.yml.config/.copier-managed-files.json.config/.coveragerc.config/pyrefly.toml.config/ruff.toml.devcontainer/devcontainer.json.devcontainer/install-ci-tooling.py.github/workflows/hash_git_files.py.pre-commit-config.yamlAGENTS.mdcopier_template_resources/vcrpy_fixtures.pyextensions/context.pypyproject.tomlpyrightconfig.jsontemplate/.claude/hooks/bash-chain-guard.jstemplate/.claude/settings/models.jsonctemplate/.claude/settings/permissions/bash.jsonctemplate/.claude/skills/address-pr-comments/fetch-pr-comments.pytemplate/.coderabbit.yamltemplate/.config/.coveragerctemplate/.config/pyrefly.tomltemplate/.config/ruff.tomltemplate/.devcontainer/devcontainer.json.jinjatemplate/.github/workflows/hash_git_files.pytemplate/.pre-commit-config.yamltemplate/AGENTS.mdtemplate/pyproject.toml.jinjatemplate/pyrightconfig.jsontemplate/tests/__init__.pytemplate/tests/conftest.pytests/__init__.pytests/conftest.py
💤 Files with no reviewable changes (3)
- template/pyproject.toml.jinja
- template/pyrightconfig.json
- pyrightconfig.json
ejfine
marked this pull request as ready for review
August 12, 2026 16:00
idonaldson
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in upstream template changes
Tested in downstream repo
Summary by CodeRabbit
New Features
xxdcommand.Bug Fixes
Chores