Repository navigation
Copier update: pyrefly strict - #63
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copier update from base template pulls in typing_extensions_version (plus starlette/kiota bumps); add typing-extensions as a dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 121 files, which is 21 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Repository: LabAutomationAndScreening/copier-aws-organization/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (121)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ejfine
marked this pull request as ready for review
September 30, 2026 12:28
zendern
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Message thread
Pulls in upstream LabAutomationAndScreening/copier-base-template#225
Why is this change necessary?
The upstream base template switched type checking from pyright to strict pyrefly. Instantiating this template with those settings (verified against
aws-organization) produced 9 pyrefly errors in the generatedsrc/code, and the generatedpyproject.tomlstill listed an unpinnedpyrightdependency becausepyright_versionno longer exists in the upstream context.How does this change address the issue?
ephemeral-pulumi-deploy>=0.0.8, and a newtyping_extensions_versioncontext value).pyrightfromtemplate/pyproject.toml.jinja; addtyping-extensionsunder the upstream-managed dependencies.open-unpacking(5 errors): makeCommonWorkloadKwargsa closed TypedDict (typing_extensions.TypedDict, closed=True, PEP 728) so unpacking it intoAwsWorkload.__init__is provably safe.explicit-anyinpulumi_deploy.py.jinja(2 errors): narrow the stack config todict[str, str | ConfigValue].explicit-anyinaccount.py(2 errors): inline# pyrefly: ignore[explicit-any]on theSleepProvider.create/deleteoverrides, since their signatures must match pulumi'sdynamic.ResourceProvider._commitin.config/.copier-answers.yml(it was left atv0.0.139after the earlier base-template update, which made subsequentcopier updateruns replay already-applied diffs).What side effects does this change have?
CommonWorkloadKwargsis closed: it can no longer be subclassed with extra keys, and an open TypedDict with the same keys isn't assignable to it. Nothing in the template does either.typing-extensionsbecomes a direct dependency of generated repos.How is this change tested?
Pulled through into
aws-organizationviacopier update;pre-commit run -apasses there (pyrefly: 0 errors, 2 suppressed).Other
Depends on LabAutomationAndScreening/copier-base-template#225 being merged and tagged; the answers file currently points at a dev version of that branch.
🤖 Generated with Claude Code