Repository navigation
fix(deps): bump urllib3 to 2.8.0 (GHSA-8988-9cw3-xx77, GHSA-gh4c-6fx4-qh6g) - #124
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the two open Dependabot alerts on
urllib3by bumping it 2.7.0 → 2.8.0 (lock-only; nopyproject.tomlchange).Advisories
>=1.26.0,<2.8.0.>=2.6.2,<2.8.0.Exploitability here
urllib3is a runtime transitive dependency throughrequests, and it ships in both the PyPI wheel's dependency set and the standalone binaries. The CLI makes HTTP calls for remote scans (hf://and HTTP URLs), OSV/PyPI lookups, the version check and telemetry. So the code is reachable for users behind an HTTPS proxy (first advisory), and for any remote target served with chunked deflate (second advisory, which is a DoS). Treating it as user-facing.Change
poetry update urllib3touched only theurllib3entry inpoetry.lock. Poetry also restated an equivalent numpy marker; I reverted that hunk so the diff covers only this fix.poetry check --lockpasses.Verification
poetry run pytest --cov=aisbom --cov-fail-under=85: 1498 passed, 93.79% coverage.--strict,--lint,--no-fail-on-risk,diff, error paths, stdout+stderr+exit codes): byte-identical between urllib3 2.7.0 and 2.8.0 after normalization. The harness was confirmed deterministic first.scripts/build_binaries.shon macOS arm64. Frozen-binary smoke test:--versionOK, CRITICAL mock artifact still exits2, and a livehf://google-bert/bert-base-uncasedscan over HTTPS exits0.No user-visible changes.