Skip to content

tokens: transactional core is untested and the package carries dead declarations and an unused generated mock - #2273

Draft
Effi-S wants to merge 1 commit into
mainfrom
fix-2266
Draft

tokens: transactional core is untested and the package carries dead declarations and an unused generated mock#2273
Effi-S wants to merge 1 commit into
mainfrom
fix-2266

Conversation

@Effi-S

@Effi-S Effi-S commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #2266

Split from #2190

Just the stale Interface removal

Where

  • Dead declarations, confirmed to have zero references anywhere in the repo outside their own declaration:
    • type Transaction interface (tokens.go:40)
    • type GetTMSProviderFunc = func() *token.ManagementServiceProvider (tokens.go:34)
    • type UnspendableTokensIterator = driver.UnsupportedTokensIterator (tokens.go:37)

Severity

Low — a coverage and cleanup gap, not a runtime defect.

@Effi-S Effi-S added this to the Q3/26 milestone Aug 19, 2026
@Effi-S Effi-S self-assigned this Aug 19, 2026
Signed-off-by: Effi-S <effi.szt@gmail.com>
@Effi-S
Effi-S marked this pull request as ready for review August 19, 2026 15:56
@Effi-S Effi-S assigned adecaro and unassigned Effi-S Aug 19, 2026
@Effi-S
Effi-S marked this pull request as draft August 19, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tokens: transactional core is untested and the package carries dead declarations and an unused generated mock

3 participants