Repository navigation
Conversation
…comcom#84) The vendored /status answers accounts as an array of account objects; decoding it into an int failed silently, Accounts stayed 0, and the channel judged itself logged out forever after a successful OAuth — ensureCodeartsProvider then disabled the managed provider every round. Also stop discarding the unmarshal error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84 — after a successful Huawei Cloud OAuth the channel still reported 未登录 and no
codearts/*model ever reached an agent picker.The embedded hub's
/statusanswersaccountsas an array of account objects (h.cfg.Pool.List()), butprobeCodeartsdecoded it into anint. The unmarshal error was discarded with_ =, soAccountsstayed 0,LoggedIn = Accounts > 0stayed false, andensureCodeartsProviderdisabled the managed provider on every round — while the hub sitting on 8096 had the account loaded and was serving/v1/modelshappily.What it does
[]json.RawMessageand counted. The parse moved intoparseCodeartsAccounts, which returns the error instead of dropping it, so a malformed/statussays so on the card rather than quietly reading as "no account loaded".Verified:
go vet ./...+go test ./...green. Reported against v1.7.17 and master; the diagnosis and the suggested shape come from the issue itself.