Async await#2
Open
Krishan-Mishra wants to merge 2 commits into
Open
Conversation
mayanktyagi45
suggested changes
Sep 18, 2023
| document.getElementById("btn-search-genre").onclick = genreButton; | ||
| document.getElementById("btn-search-price").onclick = priceButton; | ||
|
|
||
| function IdButton(event) { |
There was a problem hiding this comment.
function name should be in the camelCase in js (by convention)
| insertDataInHtml(matchingBooks); | ||
| } | ||
|
|
||
| function genreButton(event) { |
There was a problem hiding this comment.
use es6 syntax as much as possible at every instance
Owner
Author
There was a problem hiding this comment.
Noted and applied wherever possible
| `; | ||
| tableBody.appendChild(row); | ||
| data.forEach((book) => { | ||
| let row = document.createElement("tr"); |
There was a problem hiding this comment.
please change the name of this variable "row" to something else
Krishan-Mishra
force-pushed
the
async-await
branch
from
6f70f17 to
a3ffad9
Compare
Krishan-Mishra
force-pushed
the
async-await
branch
from
c5cd607 to
c5dfd70
Compare
Krishan-Mishra
force-pushed
the
javascript
branch
from
4a507cd to
0e10b0c
Compare
Krishan-Mishra
force-pushed
the
async-await
branch
from
c5dfd70 to
5895689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Display books in table using async-await method