Javascript by Krishan-Mishra · Pull Request #1 · Krishan-Mishra/JavaScript-Assignment-2

Krishan-Mishra · 2023-09-13T10:52:23Z

Added the generate book data code
Added the promise fetch functionality to render the data in frontend including all search implmentation

… json file

mayankcompro · 2023-09-18T04:48:39Z

@@ -0,0 +1 @@
+node_modules/


Add last line as empty.

mayankcompro · 2023-09-18T04:52:36Z

+function IdButton(event) {
+  event.preventDefault();
+  const idValue = document.getElementById("input-search-id").value;
+  if (idValue.trim().length <= 0) return;


I am not sure why length will go less than 0.
The above line can be written as -

if (i!dValue.trim().length) return;

Please validate.

mayankcompro · 2023-09-18T04:56:07Z

+  })
+  .catch((error) => console.log(error));
+
+document.getElementById("btn-search-id").onclick = IdButton;


Read about how onClick event is added in ES6.
The above line can be written as -

document.getElementById('btn-search-id').addEventListener('click', IdButton);

The function naming is not self explanatory. What is the work of IdButton?

Similarly there are other instances where improvement is needed.

mayankcompro · 2023-09-18T05:01:47Z

+function genreButton(event) {
+  event.preventDefault();
+  const genreValue = document.getElementById("input-search-genre").value;
+  if (genreValue.trim().length <= 0) return;


Same as above.

mayanktyagi45 · 2023-09-18T04:53:21Z

+      id="div-search-price"
+      class="container"
+      style="margin-bottom: 20px; padding-top: 20px"
+    >


Don't use an extra line for this closing bracket. Add it in the line 20 itself. Implement it at all the instances

mayanktyagi45 · 2023-09-18T04:55:07Z

+
+const bookList = new Array();
+
+for (let i = 1; i <= 100; i++) {


Use some more meaningful name instead of "i" like index or something

AyushChaudhary2002 · 2023-09-18T04:50:04Z

@@ -0,0 +1 @@
+node_modules/


remove git error

AyushChaudhary2002 · 2023-09-18T04:52:04Z

+document.getElementById("btn-search-genre").onclick = genreButton;
+document.getElementById("btn-search-price").onclick = priceButton;
+
+function IdButton(event) {


use ES6 syntax

AyushChaudhary2002 · 2023-09-18T04:54:46Z

+  }
+}
+
+function generateRandomBook(bookId) {


add this method to inside in class

AyushChaudhary2002 · 2023-09-18T05:02:26Z

@@ -0,0 +1,43 @@
+const fs = require("fs");
+


remove extra space

AyushChaudhary2002 · 2023-09-18T05:17:17Z

+  </head>
+
+  <body>
+    <div


use semantic tag

AyushChaudhary2002 · 2023-09-18T05:17:47Z

+      <form action="#">
+        <input
+          type="text"
+          id="input-search-id"


don't use id instead use class

AyushChaudhary2002 · 2023-09-18T05:20:46Z

+          type="text"
+          id="input-search-genre"
+          class="form-control"
+          style="width: 25%; display: inline"


add separate style file

mayankcompro · 2023-09-18T12:29:44Z

@@ -0,0 +1,66 @@
+let BookData = [];


This is usually a way to name the class. Variable name should be - let bookData = [];

mayankcompro · 2023-09-18T12:32:49Z

+  insertDataInHtml(matchingBooks);
+};
+
+const searchByGenreButton = (event) => {


Instead of event use evt.
event is not a reserved keyword, but it is a global variable in IE at least.

mayankcompro · 2023-09-18T12:34:00Z

+    const price = faker.finance.amount(5, 30, 2);
+    this.bookId = bookId;
+    this.genre = genre;
+    this.price = price;


Instead of defining a price variable you can directly used as follows -
this.price = faker.finance.amount(5, 30, 2);

Added the functionality to generate 100 random books and write in the…

dd2dcfd

… json file

mayankcompro suggested changes Sep 18, 2023

View reviewed changes

mayanktyagi45 suggested changes Sep 18, 2023

View reviewed changes

AyushChaudhary2002 suggested changes Sep 18, 2023

View reviewed changes

Krishan-Mishra force-pushed the javascript branch from 08c53d7 to 0fc6f36 Compare September 18, 2023 08:48

Krishan-Mishra added 2 commits September 18, 2023 14:26

Added the fetch data and display data on table

652ad5d

Handle side cases of empty input field

bc5a6a9

Krishan-Mishra force-pushed the javascript branch from 0fc6f36 to bc5a6a9 Compare September 18, 2023 08:58

mayankcompro suggested changes Sep 18, 2023

View reviewed changes

Applied suggested changes

0e10b0c

Krishan-Mishra force-pushed the javascript branch from 4a507cd to 0e10b0c Compare September 22, 2023 08:56

m-a-mohsen approved these changes Sep 25, 2023

View reviewed changes


		const bookList = new Array();

		for (let i = 1; i <= 100; i++) {

+                </head>
+                <body>
+                  <div

		@@ -0,0 +1 @@
		node_modules/ No newline at end of file

		@@ -0,0 +1 @@
		node_modules/ No newline at end of file

Conversation

Krishan-Mishra commented Sep 13, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AyushChaudhary2002 Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AyushChaudhary2002 Sep 18, 2023 •

edited

Loading