integration: qualify engine, SDK and packaging for Working

.bloat-baseline.txt

@@ -12,7 +12,6 @@ GameModules/SparkGameFPS/Source/Game/HUDSystem.h
 GameModules/SparkGameFPS/Source/Game/InteractiveObject.cpp
 GameModules/SparkGameFPS/Source/Game/InteractiveObject.h
 GameModules/SparkGameFPS/Source/Game/InventorySystem.h
-GameModules/SparkGameFPS/Source/Game/MultiplayerSystem.cpp
 GameModules/SparkGameFPS/Source/Game/MultiplayerSystem.h
 GameModules/SparkGameFPS/Source/Game/Player.cpp
 GameModules/SparkGameFPS/Source/Game/Player.h
@@ -49,8 +48,6 @@ SparkEditor/Source/AssetPipeline/AssetProcessors.cpp
 SparkEditor/Source/CommandHistory.h
 SparkEditor/Source/Communication/CollaborativeEditSession.cpp
 SparkEditor/Source/Communication/CollaborativeEditSession.h
-SparkEditor/Source/Communication/EngineInterface.cpp
-SparkEditor/Source/Communication/EngineInterface.h
 SparkEditor/Source/Core/EditorCrashHandler.cpp
 SparkEditor/Source/Core/EditorLayoutManager.cpp
 SparkEditor/Source/Core/EditorLogger.h
@@ -237,7 +234,6 @@ SparkEngine/Source/Graphics/FastNoiseLite.h
 SparkEngine/Source/Graphics/FoliageImpostorBaker.h
 SparkEngine/Source/Graphics/FoliageRenderer.h
 SparkEngine/Source/Graphics/FrustumCulling.h
-SparkEngine/Source/Graphics/GLTFStaticMeshLoader.cpp
 SparkEngine/Source/Graphics/GPUDebugMarkers.h
 SparkEngine/Source/Graphics/GPUSceneBuffer.h
 SparkEngine/Source/Graphics/GPUTimestampQuery.h
@@ -283,7 +279,6 @@ SparkEngine/Source/Graphics/RenderGraph/RenderGraphBuilder.h
 SparkEngine/Source/Graphics/RenderGraphTypes.h
 SparkEngine/Source/Graphics/RenderTarget.h
 SparkEngine/Source/Graphics/RenderTargetPool.h
-SparkEngine/Source/Graphics/SVGRenderer.h
 SparkEngine/Source/Graphics/ScreenCapture.h
 SparkEngine/Source/Graphics/ScreenSpaceEffects.h
 SparkEngine/Source/Graphics/Shader.h
@@ -325,7 +320,6 @@ SparkEngine/Source/Utils/ConfigParser.h
 SparkEngine/Source/Utils/ConsoleVariable.h
 SparkEngine/Source/Utils/CpuDebugger.h
 SparkEngine/Source/Utils/CrashHandler.cpp
-SparkEngine/Source/Utils/CrashReportUploader.cpp
 SparkEngine/Source/Utils/DaemonFraming.h
 SparkEngine/Source/Utils/DebugDraw.h
 SparkEngine/Source/Utils/DebugHookManager.h

.claude/skills/sparkengine-architecture-contract/SKILL.md

@@ -110,13 +110,12 @@ silent Release-only correctness bug.
 **How to add a subsystem correctly:**
 1. Add the owning `std::unique_ptr<T>` field to `EngineRuntime` (feature-gated
    systems get an `#ifdef` guard like `physics`).
-2. Create it on the startup path and register it with dependency-aware
-   registration:
-   `ctx.RegisterSubsystem<T>(ptr, DependsOn<Dep1, Dep2>{}, initFn, shutdownFn)`
-   so `InitializeAll()`/`ShutdownAll()` order it topologically. Follow the
-   existing wiring in `Core/EngineSetup.h` (e.g.
-   `RegisterSubsystem<Spark::UI::UISystem>(ui, DependsOn<Timer, Spark::EventBus>{})`).
-   Plain `RegisterSystem<T>(ptr)` is only for systems with no init/deps.
+2. Create and initialize it in the `LifecycleCompositionRoot` stage that owns
+   its phase (`Core/Lifecycle/`), tear it down in that stage's `Shutdown()`,
+   and publish it with `ctx.RegisterSystem<T>(ptr)` (or the named setter);
+   null the registration before the owner is destroyed. `EngineContext` has
+   no init/shutdown ordering of its own (`InitializeAll`/`ShutdownAll` were
+   deleted by OD-01).
 3. Never store the pointer in a file-scope global. Fetch via
    `EngineContext::Get()->GetSystem<T>()` at the call site.
 4. Wire its `Update()` into the real loop in the same change (Invariant 4).
@@ -307,9 +306,9 @@ CI.
 ## Quick self-check before committing an architecture-touching change
 
 - [ ] No new `g_*` file-scope subsystem global (Invariant 1).
-- [ ] New subsystem: owned in `EngineRuntime`, registered via
-      `RegisterSubsystem<T>(..., DependsOn<...>{}, ...)`, fetched via
-      `EngineContext::Get()` (Invariant 1).
+- [ ] New subsystem: owned in `EngineRuntime`, created and torn down in a
+      `LifecycleCompositionRoot` stage, published via `RegisterSystem<T>` /
+      named setter, fetched via `EngineContext::Get()` (Invariant 1).
 - [ ] Did not add `const` to `GetTypeId<T>()`'s `static char id` (Invariant 1).
 - [ ] Module-side access uses `EngineContext::Get()`; no new per-module
       `static T instance;` singleton (Invariant 2).
@@ -346,8 +345,8 @@ one-liners (run from the repo root):
 grep -n "unique_ptr\|GetEngineRuntime" SparkEngine/Source/Core/EngineRuntime.h
 # Invariant 1 — type-id must stay non-const; registry lock
 grep -n "static char id\|shared_mutex" SparkEngine/Source/Core/EngineContext.h
-# Invariant 1 — dependency-aware registration in use
-grep -n "RegisterSubsystem<" SparkEngine/Source/Core/EngineSetup.h | head
+# Invariant 1 — lifecycle owned by EngineRuntime + LifecycleCompositionRoot stages
+grep -rn "GetEngineRuntime\|RegisterSystem<" SparkEngine/Source/Core/Lifecycle | head
 # Invariant 2 — Get() prefers injected pointer; export + host consumption
 grep -n "g_injectedContext\|SetInjected" SparkEngine/Source/Core/EngineContext.cpp
 grep -n "SparkModuleInjectEngineContext" SparkSDK/Include/Spark/ModuleDllMain.h SparkEngine/Source/Core/ModuleManager.cpp

.claude/skills/sparkengine-build-ci-and-dependencies/SKILL.md

@@ -344,11 +344,19 @@ Advisory (job-level `continue-on-error: true`; never block merges):
 advisory, but configure/compile failures block). Canonical required-vs-advisory
 fine print: `sparkengine-validation-and-qa` §10.
 
-**Shipping symbols:** `windows-shipping` (MinSizeRel) links **without** `/DEBUG`, so it emits no PDB
-and no PDB path, and `linux-shipping` links with `-s`. Runtime `SymFromAddr` symbolication and
-post-mortem minidump analysis of a shipping build change accordingly, and `SparkCrashReporter`
-output for a shipping build is address-only. The `SPARK_STRIP_DEBUG_SYMBOLS` compile definition was
-removed (zero remaining source references) — external tooling keying on it must stop.
+**Shipping symbols (BLD-100):** `STRIP_DEBUG_SYMBOLS=ON` keeps symbols out of the runtime
+*package*, not out of the build. MSVC always links `/DEBUG` (`/PDBALTPATH:$<TARGET_PDB_FILE_NAME:...>` outside
+Debug: the image records only the PDB name plus GUID/age; never the linker's `%_PDB%` macro, which
+the Visual Studio generator escapes into a literal `%%%<name>.pdb%%%`). ELF images link `-Wl,--build-id=sha1`; with the
+option on everything compiles `-g`; only `SPARK_SHIPPED_IMAGE_TARGETS` get
+`cmake/SparkSplitDebugLink.cmake` as their per-target `LINKER_LAUNCHER`, which splits
+`<image>.debug` off and strips the image at link time, before any `POST_BUILD` step. Every other
+image (SparkTests, probes) links `-g0 -Wl,--strip-all` outside Debug, so no `.debug` is produced. PDBs and
+`.debug` files install only into the `symbols` component (never in `CPACK_COMPONENTS_ALL`);
+`tools/shipping_symbol_manifest.py` proves each staged image maps to exactly one symbol file. A new
+installed image target must be added to `SPARK_SHIPPED_IMAGE_TARGETS` (root CMakeLists.txt) —
+`ShippingManifest_SymbolManifestTool` fails otherwise. The `SPARK_STRIP_DEBUG_SYMBOLS` compile
+definition was removed (zero remaining source references) — external tooling keying on it must stop.
 
 **Windows installers are opt-in:** `SPARK_REQUIRE_WINDOWS_INSTALLERS` (set ON by `release.yml`)
 makes the NSIS/WiX generators mandatory. Without it a developer `cpack` on Windows produces a ZIP

.claude/skills/sparkengine-change-control-and-release-readiness/SKILL.md

@@ -146,9 +146,10 @@ Work-item schema (every field required by `validate.py`): `id`, `title`, `priori
 `rationale`, `sourceContext`, `entryPoints`, `implementationScope`, `acceptanceCriteria`,
 `commands`, `testSelectors`, `requiredCiJobs`, `performanceBudgets`,
 `documentationUpdates`, `readinessChanges`, `websiteImpact`, `risks`, `outOfScope`,
-`definitionOfDone`. Validation is fail-closed: every referenced path must exist unless
-listed in `FUTURE_ACCEPTANCE_PATHS` inside `validate.py` (deliberate outputs of
-unfinished items).
+`definitionOfDone`. Validation is fail-closed: every `entryPoints`,
+`documentationUpdates`, `sourceContext` and docs-catalog path must exist, for open and
+done items alike. A planned output is referenced only after it lands; use
+`plannedTestSelectors` / `plannedCiJobs` for tests and jobs that do not exist yet.
 
 **`plannedCiJobs` / `plannedTestSelectors` — the honest way to reference something that does not
 exist yet.** `requiredCiJobs` must name a job that really exists in `.github/workflows/`, and
@@ -214,8 +215,8 @@ Checklist per new/changed system:
 
 - [ ] **Caller** — `Initialize()` invoked in the startup path (`SparkEngine.cpp` /
   `EngineContext` / `EditorApplication`), not just defined.
-- [ ] **Registration** — registered via `EngineContext` `RegisterSystem<T>()` /
-  `RegisterSubsystem<T>()`; panels in `EditorPanelFactory`; tests in `Tests/CMakeLists.txt`.
+- [ ] **Registration** — published via `EngineContext` `RegisterSystem<T>()` / named
+  setter (owned in `EngineRuntime`, created in a `LifecycleCompositionRoot` stage); panels in `EditorPanelFactory`; tests in `Tests/CMakeLists.txt`.
 - [ ] **Tick** — `Update()`/`ProcessCommands()` appears in the main loop.
 - [ ] **Teardown** — shutdown/unload path is real. Clean module/resource teardown is
   gate `G10` territory and tracked as open item `LIFE-200` — if your teardown is

.claude/skills/sparkengine-ecs-lifecycle-threading-and-memory/SKILL.md

@@ -180,16 +180,18 @@ thin wrapper over one `entt::registry`. `EntityID = entt::entity`
   first, so the callback may safely enqueue new items (processed next flush)
   and exceptions in the callback are caught and logged, not propagated.
   `DeferredQueue` is **not thread-safe** — synchronize externally.
-- Production examples: `LifecycleSystem` (death), `DecalSystem` (expiry),
-  `ProjectileSystem` (expiry) each keep a persistent member queue to avoid
-  per-frame heap allocation.
-
-**Lifecycle events:** `LifecycleSystem` fires its `DeathCallback` once per
-entity per `HealthComponent::isDead == true` detection; the callback (single
-slot, last-set wins) is responsible for destroying the entity or clearing the
-flag, otherwise it fires again next frame. Registration:
-`lifecycleSys->SetDeathCallback(...)` via
-`GetPhaseSystemManagerImpl().GetSystem("LifecycleSystem")`.
+- Production examples: `DecalSystem` (expiry) and `ProjectileSystem` (expiry)
+  each keep a persistent member queue to avoid per-frame heap allocation.
+
+**Lifecycle events:** `LifecycleSystem` has no death callback (one existed but
+production never registered it, so it was removed). It only latches
+`HealthComponent::deathProcessed` the first frame it sees `isDead == true`.
+The death response and `Spark::EntityKilledEvent` belong to the gameplay system
+that dealt the lethal damage (`AbilitySystem` publishes it for ability kills);
+subscribe on the EventBus. Anything that revives an entity must clear both
+flags: `HealthComponent::Revive()`, or `HealthComponent::SetHealth()` for an
+authoritative write (snapshot, respawn); otherwise the next death is never
+latched and `InvalidStateDetector` reports `deathProcessed=true but isDead=false`.
 
 **Hierarchy:** `Transform.parent` (`entt::null` = root) + `children` vector.
 Origin rebasing (§5) shifts **root transforms only**; children inherit.

.claude/skills/sparkengine-editor-scenes-and-reflection/SKILL.md

@@ -43,7 +43,7 @@ loader rejects the other's files cleanly.
 | Code | `SparkEngine/Source/SceneManager/ReflectedSceneSerializer.{h,cpp}` (`Spark::SaveWorld/LoadWorld/SerializeWorld/DeserializeInto`) | `SparkEditor/Source/SceneSystem/SceneSerializer.{h,cpp}` + `JSONSceneSerializer.cpp` + `SceneComponentCodec.{h,cpp}` |
 | Document type | live ECS `World` | `SparkEditor::SceneFile` |
 | Top-level shape | `{"version": 1, "entities": [...]}` | `{"version": 2, "objects": [...], "components": [...], "environment": {...}, ...}` |
-| Version gate | `"version": 1` is **written but not checked** on load; load only requires an `entities` array | `version` must appear **exactly once** and equal `SCENE_FILE_VERSION` (= 2) or the load fails closed |
+| Version gate | `"version": 1` (or legacy `"sceneVersion": 1`, exactly one of them) must equal 1 **exactly**; no N-1 window, and any other value fails with a bare `false` and no versioned diagnostic (OD-03 gap tracked under SAVE-230) | `version` must appear **exactly once** and be 2 (N) or 1 (N-1, migrated in memory) or the load fails closed with a versioned error |
 | Per-component schema | Fields serialized **as strings** via reflection (`TypeRegistry`/`ComponentFactory`); only fields with `serialized == true`; unknown component types are **skipped with a warning** | Non-marker components require `data: {"schema": 1, "fields": {...}}` where 1 = `SCENE_COMPONENT_SCHEMA_VERSION`; unknown types, wrong schema, or malformed payloads **reject the whole file** |
 | Who uses it in the running editor | **File → Open / Save** (`EditorUI::OpenScene` / `EditorUI::SaveCurrentScene` in `SparkEditor/Source/Core/EditorUI.cpp`, "full-fidelity scene round-trip (C4)") | SceneFile-backed panels (legacy Hierarchy/Inspector fallback path, Physics2D/3D, Tilemap, PostProcessing panels, PrefabManager) and `SceneManager` |
 | Tests | `Tests/TestReflectedScene.cpp`, `Tests/TestReflectedSceneEmissiveHierarchy.cpp` | `Tests/TestSceneSerializer.cpp`, `Tests/TestSceneSerializerReal.cpp` |
@@ -78,15 +78,22 @@ schema-design task, not a bug fix — do not delete the guards.
 
 | Constant | Value | Where | Load behavior on mismatch |
 |---|---|---|---|
-| `SCENE_FILE_VERSION` | 2 | `SceneSystem/SceneFileTypes.h` | Exact match required, field must appear exactly once → whole-file rejection: "Scene file version is unsupported; legacy raw-memory scene payloads must be resaved by a trusted build" |
+| `SCENE_FILE_VERSION` / `SCENE_FILE_OLDEST_READABLE_VERSION` | 2 / 1 | `SceneSystem/SceneFileTypes.h` | Field must appear exactly once and be 1 or 2 (v1 migrates in memory; raw v1 payloads fail closed) → otherwise whole-file rejection with a versioned error naming the window |
 | `SCENE_COMPONENT_SCHEMA_VERSION` | 1 | `SceneSystem/SceneComponentCodec.h` | Per-component `data.schema` must equal 1, `data` must contain exactly `schema` + `fields` → whole-file rejection |
-| Reflected-World `"version"` | 1 | `SceneManager/ReflectedSceneSerializer.cpp` (`root["version"] = 1`) | Written on save, **not validated on load** (only `entities` is required) — labeled `open`: a future v2 has no gate yet |
+| Reflected-World `"version"` | 1 | `SceneManager/ReflectedSceneSerializer.cpp` (`root["version"] = 1`) | Written on save; load requires `version` (or legacy `sceneVersion`) == 1 exactly (`ReflectedSceneSerializer.cpp` `LoadWorld`/`ValidateStrictRecoveryDocument`) and rejects anything else with a bare `false` — `open`: no N-1 window or versioned diagnostic yet (SAVE-230) |
 | `TypeInfo::version` (`SPARK_REFLECT_VERSION`) | per-type | `SparkEngine/Source/Core/Reflection.h` | Reflection schema version for save-file migration; migration mechanics belong to sparkengine-persistence-save-and-migrations |
 
-There is **no scene migration path**: `SceneSerializer::HandleVersionCompatibility`
-rejects any `fileVersion != 2` with a warning; it never upgrades. Old files must be
-resaved by a build that wrote them. (Verified: `TestSceneSerializerReal.cpp` feeds
-`{"version":3}` and a header with `SCENE_FILE_VERSION + 1` and expects rejection.)
+**Scene migration window (OD-03): read v2 (N) and v1 (N-1), write v2.**
+`SceneSerializer::HandleVersionCompatibility` accepts
+`SCENE_FILE_OLDEST_READABLE_VERSION..SCENE_FILE_VERSION` (1..2), upgrades a v1 document
+in memory (header, objects, hierarchy, marker components, environment, camera, asset
+references) and adds a "migrated in memory" warning; the file is untouched until saved.
+A v1 component carrying a raw object-image `data` hex string (or any non-marker v1
+component) fails closed: "Scene file version 1 component <Type> carries a raw
+object-image payload that cannot be migrated to version 2". Any other version fails
+with "Scene file version X is unsupported: this build reads scene versions 1-2 and
+writes version 2; ...". Fixtures: `Tests/Fixtures/Compatibility/SceneFile/` (real v1
+writer output); tests: `SceneMigration_*` (CTest `SparkSceneCompatibilityTests`).
 
 ### Dialect B hardening behaviors (all verified in `JSONSceneSerializer.cpp`)
 
@@ -213,7 +220,7 @@ conditional visibility.
 
 | Symptom | Cause / where to look |
 |---|---|
-| "Scene file version is unsupported; legacy raw-memory scene payloads must be resaved…" | Dialect B loader saw `version` ≠ 2, duplicated, or missing. No migration exists — resave from a trusted build. |
+| "Scene file version X is unsupported: this build reads scene versions 1-2…" / "Scene file must declare exactly one \"version\" field" | Dialect B loader saw a version outside 1..2, or a duplicated/missing version. Newer: open with the newer build. Older: convert with an older build first. |
 | "Scene component requires a registered schema-tagged data object" / "data schema is invalid" | Component `data` missing `{"schema":1,"fields":{}}` shape, or type has no codec (`HasSceneComponentPayloadCodec` in `SceneComponentCodec.cpp`). |
 | "Marker-only scene component must not contain data" | `TRANSFORM`/`SPRITE_ANIMATOR` entry carries a `data` object — remove it. |
 | File → Open fails, console: "Failed to open scene (Spark::LoadWorld)" | Wrong dialect (no `entities` array), unparseable JSON, or unreadable path. Current document is untouched by design. |
@@ -232,7 +239,7 @@ conditional visibility.
 | Reflected-World round trip (transform, mesh, enums/masks, hierarchy) | Implemented + tested (`TestReflectedScene.cpp`, `TestReflectedSceneEmissiveHierarchy.cpp`, registered) + CI-enforced |
 | Undo/redo stack, merge, saved-sequence dirty tracking | Implemented + tested (`TestUndoRedoManager.cpp`, `TestCommandHistory.cpp`, registered) + CI-enforced |
 | SwapWorld history-clear ordering (UAF prevention) | Implemented; enforced by code structure + debugging-playbook check; no dedicated automated test found — treat as code-reviewed, not test-proven |
-| Reflected-World load-time version gate | `open` — version written, never checked |
+| Reflected-World load-time version gate | Exact-match gate (== 1) implemented; OD-03 N-1 window and versioned diagnostic `open` (SAVE-230) |
 | World-backed Inspector undo support | `open` — edits bypass CommandHistory |
 | Blocking unsaved-changes exit prompt | `open` — log-only today |
 | `SparkEditor::SceneManager` (`SceneSystem/SceneManager.{h,cpp}`) | `candidate` — compiled but **no instantiation found anywhere** in editor/engine/tests (the `SceneManager` built in game modules is the engine class, a different type). Per the project's wire-in-or-delete rule, wire it or delete it before building on it. |
@@ -284,7 +291,7 @@ ls SparkEditor/Source/Gizmos
 grep -n "SCENE_FILE_VERSION = " SparkEditor/Source/SceneSystem/SceneFileTypes.h
 grep -n "SCENE_COMPONENT_SCHEMA_VERSION = " SparkEditor/Source/SceneSystem/SceneComponentCodec.h
 # Fail-closed gates still in place
-grep -n "version is unsupported" SparkEditor/Source/SceneSystem/JSONSceneSerializer.cpp
+grep -n "is unsupported: " SparkEditor/Source/SceneSystem/SceneSerializer.cpp
 grep -n "Refusing unsupported binary scene" SparkEditor/Source/SceneSystem/BinarySceneSerializer.cpp
 # Reflected dialect still writes version 1 and requires "entities"
 grep -n "root\[\"version\"\] = 1\|contains(\"entities\")" SparkEngine/Source/SceneManager/ReflectedSceneSerializer.cpp

.claude/skills/sparkengine-modules-sdk-abi-and-hot-reload/SKILL.md

@@ -57,7 +57,7 @@ protection each of those steps really gives you.
 - **Injection hook** — an `extern "C" __declspec(dllexport)` function the host resolves via
   `GetProcAddress` right after `LoadLibrary` and calls to point the DLL's per-image globals at
   host-owned objects. Windows-only (`#if defined(_WIN32)`).
-- **SDK version** — `SPARK_SDK_VERSION` (currently **2**) in `SparkSDK/Include/Spark/Version.h`.
+- **SDK version** — `SPARK_SDK_VERSION` (currently **5**) in `SparkSDK/Include/Spark/Version.h`.
   An integer ABI stamp baked into each module at compile time via `ModuleInfo::sdkVersion`.
 - **Game vs Addon** — `Spark::ModuleKind` in `SparkSDK/Include/Spark/IModule.h`. Exactly one
   `Game` module per process (game modules own the simulation); `Addon` modules coexist freely.