Repository navigation
Conversation
Contributor
⏳ CodeQL Report PendingThe pull-request head changed. Results from earlier commits do not apply while the new head is being scanned. Current PR head: |
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPS weather and state-validation adapters previously depended on private engine interfaces. This change exposes weather through SDK ABI 10 and moves those adapters onto public services, reducing the measured FPS private-header count from 38 to 36. Unsupported weather commands retain explicit refusal behavior; full FPS SDK isolation remains open.
The reflected gameplay loader now preserves the supported authored spawn-point subset and rejects unsupported semantics instead of discarding them. Default-off input observations follow the existing production F2/F3 dispatch. The proposed installed check sends keys only to the owned game window, verifies held-key and release/repress behavior, and decodes the resulting primary save through production SaveSystem code in a separate process. Missing-slot load must fail without changing the immediate profile or creating a save.
The combined qualification is designed to reuse one exact-source MinSizeRel Windows build for 29 focused cases, the four editor-author/cook/package/installed-FPS lineage cases, installed public SDK weather acceptance, SDK 9/11 rejection, runtime dependency closure and the persistence input/decoder check. Product and workflow commits are pinned separately. The lineage cases retain their two-entity fixture and strict WARP/module lifecycle checks; they do not qualify packaged spawn-point behavior.
Product
25548f70f515af9445af7e4ed187e5ea7af87e3cpassed five final correction/documentation check groups and retains the hash-bound P3 source-check chain. The correction replaces two ambiguous JSON zero indices with typed array indices without changing assertions. Workflow commit0a2678215f3c65a36da231487312fbf418fa6eb1passed all fifteen workflow-source check groups; their retained log hashes and qualification bundle were independently verified. The earlier lineage attempt stopped at the compile error and supplied no passing runtime lineage result. Hosted native results will be reported separately against these product/workflow identities.The workflow retains the 240-minute job limit and existing phase bounds. Input and decoding share a 90-second owner budget with a 30-second limit per engine process. Complete bounded text evidence must fit the existing 128-KiB runtime-proof, 900,000-byte expanded and 1,000,000-byte ZIP limits; overflow or missing proof fails qualification. No native success is claimed by this PR description.
Full normal-input gameplay, physical Windows 11 graphics/performance, Wine/DXVK, MSI/signing and completed weather transitions remain separate gates. Profile load does not establish world or player-position restoration. Earlier Release/installed results retain their original source identities.