Permit building with flit core 4 - #76
Merged
Merged
Conversation
Signed-off-by: Xu Colin <colinxu2020@gmail.com>
Member
|
Thanks for the pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to flit changelog, this project does not use any of removed features in flit core 4, and this project use
[project]instead of removed[tool.flit.metadata], so it should be safe to build via flit-core 4. I've already tested this locally and it looks good.Therefore this PR relax the requirement of flit core to
>=3.2,<5to make the project be able to build with flit core 4。Among the distros I searched, I've found that Void Linux has already use downstream patch to permit building this package with flit core 4 and it seems fine. So this issue has already affected distro packaging.