Repository navigation
config: fix reference config entries that differ from the defaults - #2406
Merged
Merged
Conversation
uc_username has been an option since 3.3.2 but was the only [auth] option missing from the reference config. Assisted-by: Claude Opus 5.5
The config parser keeps quotes, so uncommenting these lines set the value with the quotes: - group_collections_folder = "GROUPS" used a folder named "GROUPS" with the quotes instead of the default GROUPS - conversion_bday_alarm_trigger_template = "" fails at startup, since '""' is not a valid <trigger>;<alarm description> template, and the quoted example above it fails the same way, with the trigger '"-15H' - trace_filter = "" installs a filter for the prefix '""', which hides every trace message not starting with '""' instead of applying no filter Also remove the space after # on the group_collections_folder line to match the other commented options. Assisted-by: Claude Opus 5.5
8a28141 removed {n:a} from the default, but in the reference config it left the space before it behind. Uncommenting that line added a second space to the summary whenever the vCard N property has both a family and a given name, e.g. "Doe John (1980) (BDAY)". When either is missing the template falls back to {fn} or {nickname} and the output is the same. Assisted-by: Claude Opus 5.5
Collaborator
Thank you for the hint, verify and create a dedicated commit if required |
pbiering
added a commit
that referenced
this pull request
Nov 20, 2026
pbiering
added a commit
that referenced
this pull request
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some commented lines in the reference
configdid not match the defaults inradicale/config.py, or broke when uncommented:[auth] uc_usernamewas missing. It is the only[auth]option not listed there. The comment also notes that it is mutually exclusive withlc_username, since enabling both raises at startup.group_collections_folder = "GROUPS"used a folder named"GROUPS".conversion_bday_alarm_trigger_template = "", and the quoted example above it, failed at startup.trace_filter = ""installed a filter that hid trace messages.[sharing] conversion_bday_summary_templatekept a space that 8a28141 removed from the default. It added a double space to the summary when the contact has both a family and a given name.I found these by comparing every commented
#key = valueline inconfigwithDEFAULT_CONFIG_SCHEMA, and checked each one by loading the uncommented line throughradicale.config.load. One commit per change. No CHANGELOG entry, since only comments in the reference file change. Tell me if you want one.Not changed: the
[hook]linessmtp_security = starttls,smtp_server = localhostandrabbitmq_queue_type = classicalso differ from the schema defaults (none, empty, empty). They may be meant as examples, so I left them. Thelc_usernamecomment still says "must be true"; I left that neighbouring line alone.tox -c pyproject.toml -e flake8,isort,mypy,pypasses (851 passed, 15 skipped on macOS, where TEMP is not case sensitive). Thefslabel, which needs sudo, was not run.AI disclosure: written by Claude Code (Claude Opus 5.5, medium effort), working as an agent. It wrote the comparison script, the edits and this description. Following AGENTS.md, each commit went through at least three independent adversarial review agents until only nits remained; those reviews led to the
lc_usernamenote, the two extra quoted lines and the more precise commit messages. I reviewed the diff before it was opened.