Skip to content

Reject a null share path and ignore null share fields - #2402

Merged
pbiering merged 6 commits into
Kozea:masterfrom
oliviasculley:fix-sharing-json-null
Nov 20, 2026
Merged

pbiering merged 6 commits into
Kozea:masterfrom
oliviasculley:fix-sharing-json-null

Conversation

@oliviasculley

@oliviasculley oliviasculley commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

A null PathOrToken is HTTP 400. A null Properties or Actions value is left for the clear path instead of crashing the whitelist.

AI support

  • Model: Grok 4.7
  • Effort: autonomous agent session.
  • Generated parts: the null checks, the changelog bullet, and radicale/tests/test_sharing_json_null.py.
  • Verified: flake8 and isort. pytest of test_sharing_json_null.py (1 passed) on Python 3.14. The test creates the share, then sends JSON null for Properties and Actions and requires those stored fields to become empty. The full tox -m all set was not passed in this environment: sudo cannot loop-mount.

A null PathOrToken is HTTP 400. A null Properties or Actions value
is left for the clear path instead of crashing the whitelist.

Assisted-by: Grok 4.7 <noreply@x.ai>
A missing share returned 404 before the clear. Create the share, set
properties and actions, then send JSON null and require the stored
fields to become empty. An assertion error on that path is HTTP 500
and fails this test.

Assisted-by: Grok 4.7 <noreply@x.ai>
Assisted-by: Grok 4.7 <noreply@x.ai>
@pbiering pbiering added the sharing collection sharing label Nov 19, 2026

@pbiering pbiering left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thank you

@oliviasculley
oliviasculley marked this pull request as ready for review November 20, 2026 00:07
@pbiering pbiering removed the DRAFT PR in DRAFT status label Nov 20, 2026
@pbiering
pbiering merged commit a9bd688 into Kozea:master Nov 20, 2026
3 of 4 checks passed
@oliviasculley
oliviasculley deleted the fix-sharing-json-null branch November 20, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement sharing collection sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants