Repository navigation
Reject a null share path and ignore null share fields - #2402
Merged
Merged
Conversation
A null PathOrToken is HTTP 400. A null Properties or Actions value is left for the clear path instead of crashing the whitelist. Assisted-by: Grok 4.7 <noreply@x.ai>
A missing share returned 404 before the clear. Create the share, set properties and actions, then send JSON null and require the stored fields to become empty. An assertion error on that path is HTTP 500 and fails this test. Assisted-by: Grok 4.7 <noreply@x.ai>
Assisted-by: Grok 4.7 <noreply@x.ai>
pbiering
approved these changes
Nov 19, 2026
pbiering
left a comment
Collaborator
There was a problem hiding this comment.
makes sense, thank you
Assisted-by: Grok 4.7 <noreply@x.ai>
Assisted-by: Grok 4.7 <noreply@x.ai>
oliviasculley
marked this pull request as ready for review
November 20, 2026 00:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A null
PathOrTokenis HTTP 400. A nullPropertiesorActionsvalue is left for the clear path instead of crashing the whitelist.AI support
radicale/tests/test_sharing_json_null.py.test_sharing_json_null.py(1 passed) on Python 3.14. The test creates the share, then sends JSON null forPropertiesandActionsand requires those stored fields to become empty. The fulltox -m allset was not passed in this environment: sudo cannot loop-mount.